Inconsistent package_ensure parameter name

The parameter name used to enforce package state is inconsistent across
manifests and modules. I settle on package_ensure since it's already
widely used.

Change-Id: If11b95ddb6b6748d587d96dcad522d96fd58a91d
Closes-Bug: #1668732

manifests/init.pp

@@ -4,7 +4,7 @@
 #
 # === Parameters
 #
-# [*ensure_package*]
+# [*package_ensure*]
 #   (optional) The state of panko packages
 #   Defaults to 'present'
 #
@@ -13,16 +13,32 @@
 #   in the panko config.
 #   Defaults to false.
 #
+# DEPRECATED PARAMETERS
+#
+# [*ensure_package*]
+#   (optional) The state of panko packages
+#   Defaults to undef
+#
 class panko (
-  $ensure_package      = 'present',
+  $package_ensure      = 'present',
   $purge_config        = false,
+  # DEPRECATED PARAMETERS
+  $ensure_package      = undef,
 ) inherits panko::params {
 
   include ::panko::deps
   include ::panko::logging
 
+  if $ensure_package {
+    warning("panko::ensure_package is deprecated and will be removed in \
+the future release. Please use panko::package_ensure instead.")
+    $package_ensure_real = $ensure_package
+  } else {
+    $package_ensure_real = $package_ensure
+  }
+
   package { 'panko':
-    ensure => $ensure_package,
+    ensure => $package_ensure_real,
     name   => $::panko::params::common_package_name,
     tag    => ['openstack', 'panko-package'],
   }

releasenotes/notes/deprecate_ensure_package_parameter-78135a334d98fe23.yaml

@@ -0,0 +1,4 @@
+---
+deprecations:
+  - panko::ensure_package is now deprecated and will be removed in the
+    future release. Please use panko::package_ensure instead.