From 2013f996222b698576e3f60f90c2549b5fb8d3f4 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Mon, 11 Dec 2023 22:19:21 +0900 Subject: [PATCH] Use undef for package/service name ... instead of booleans, so that we can implement type enforcement more easily. Change-Id: I5d327a665e18cdaeaa9cdaea85a6fc92f320098d --- manifests/params.pp | 4 ++-- spec/classes/placement_api_spec.rb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/manifests/params.pp b/manifests/params.pp index e3e5f57..31bde7e 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -14,7 +14,7 @@ class placement::params { $common_package_name = 'openstack-placement-common' $python_package_name = 'python3-placement' $osc_package_name = 'python3-osc-placement' - $service_name = false + $service_name = undef $public_url = 'http://127.0.0.1/placement' $internal_url = 'http://127.0.0.1/placement' $admin_url = 'http://127.0.0.1/placement' @@ -31,7 +31,7 @@ class placement::params { $service_name = 'placement-api' } default: { - $service_name = false + $service_name = undef } } $public_url = 'http://127.0.0.1' diff --git a/spec/classes/placement_api_spec.rb b/spec/classes/placement_api_spec.rb index fd47d19..2d893e3 100644 --- a/spec/classes/placement_api_spec.rb +++ b/spec/classes/placement_api_spec.rb @@ -81,11 +81,11 @@ describe 'placement::api' do { :service_name => 'placement-api', :package_name => 'placement-api'} else - { :service_name => false, + { :service_name => nil, :package_name => 'placement-api'} end when 'RedHat' - { :service_name => false, + { :service_name => nil, :package_name => 'openstack-placement-api'} end end