openstack
/
puppet-placement
Code Issues Proposed changes

Use anchor to require necessary packages 

... so that correct packages are required without re-defining them in
resource implementations.

Change-Id: Iac4e6aded9e10973560e9e819c36ad395affe129
This commit is contained in:
Takashi Kajinami 2020-05-04 02:03:22 +09:00
parent 763729ec74
commit 522f2404e6
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/puppet/type/placement_config.rb
View File

@ -46,8 +46,8 @@ Puppet::Type.newtype(:placement_config) do
defaultto('<SERVICE DEFAULT>')
end
autorequire(:package) do
'placement'
autorequire(:anchor) do
['placement::install::end']
end
end

7
spec/unit/type/placement_config_spec.rb
View File

@ -1,5 +1,6 @@
require 'puppet'
require 'puppet/type/placement_config'
describe 'Puppet::Type.type(:placement_config)' do
before :each do
@placement_config = Puppet::Type.type(:placement_config).new(:name => 'DEFAULT/foo', :value => 'bar')
@ -52,12 +53,12 @@ describe 'Puppet::Type.type(:placement_config)' do
it 'should autorequire the package that install the file' do
catalog = Puppet::Resource::Catalog.new
package = Puppet::Type.type(:package).new(:name => 'placement')
catalog.add_resource package, @placement_config
anchor = Puppet::Type.type(:anchor).new(:name => 'placement::install::end')
catalog.add_resource anchor, @placement_config
dependency = @placement_config.autorequire
expect(dependency.size).to eq(1)
expect(dependency[0].target).to eq(@placement_config)
expect(dependency[0].source).to eq(package)
expect(dependency[0].source).to eq(anchor)
end