openstack/puppet-placement
Code Issues Proposed changes

Do not test detail of keystone::resource::service_identity

Browse Source 
... but test interfaces of that resource type. This helps us avoid
direct breakage caused by any change in puppet-keystone.

Change-Id: Ie30f15533229a22170b625094dfcca349f9d0b24
This commit is contained in:
Takashi Kajinami 2021-09-27 12:18:22 +09:00
parent 1a5b876f27
commit f00edeccac
1 changed files with 52 additions and 113 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

165
spec/classes/placement_keystone_auth_spec.rb
View File

@ -1,129 +1,68 @@
#
# Unit tests for placement::keystone::auth
#
require 'spec_helper' require 'spec_helper'
describe 'placement::keystone::auth' do describe 'placement::keystone::auth' do
shared_examples 'placement::keystone::auth' do shared_examples_for 'placement::keystone::auth' do
context 'with default class parameters' do context 'with default class parameters' do
let :params do let :params do
{ { :password => 'placement_password' }
:password => 'placement_password',
:tenant => 'foobar'
}
end end
it { should contain_keystone_user('placement').with( it { is_expected.to contain_keystone__resource__service_identity('placement').with(
:ensure => 'present', :configure_user => true,
:password => 'placement_password', :configure_user_role => true,
)} :configure_endpoint => true,
:service_name => 'placement',
it { should contain_keystone_user_role('placement@foobar').with( :service_type => 'placement',
:ensure => 'present', :service_description => 'Placement Service',
:roles => ['admin'] :region => 'RegionOne',
)} :auth_name => 'placement',
:password => 'placement_password',
it { should contain_keystone_service('placement::placement').with( :email => 'placement@localhost',
:ensure => 'present', :tenant => 'services',
:description => 'Placement Service' :public_url => 'http://127.0.0.1/placement',
)} :internal_url => 'http://127.0.0.1/placement',
:admin_url => 'http://127.0.0.1/placement',
it { should contain_keystone_endpoint('RegionOne/placement::placement').with( ) }
:ensure => 'present',
:public_url => 'http://127.0.0.1/placement',
:admin_url => 'http://127.0.0.1/placement',
:internal_url => 'http://127.0.0.1/placement',
)}
end end
context 'when overriding URL parameters' do context 'when overriding parameters' do
let :params do let :params do
{ { :password => 'placement_password',
:password => 'placement_password', :auth_name => 'alt_placement',
:public_url => 'https://10.10.10.10:80', :email => 'alt_placement@alt_localhost',
:internal_url => 'http://10.10.10.11:81', :tenant => 'alt_service',
:admin_url => 'http://10.10.10.12:81', :configure_endpoint => false,
}
end
it { should contain_keystone_endpoint('RegionOne/placement::placement').with(
:ensure => 'present',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
)}
end
context 'when overriding auth name' do
let :params do
{
:password => 'foo',
:auth_name => 'placementy'
}
end
it { should contain_keystone_user('placementy') }
it { should contain_keystone_user_role('placementy@services') }
it { should contain_keystone_service('placement::placement') }
it { should contain_keystone_endpoint('RegionOne/placement::placement') }
end
context 'when overriding service name' do
let :params do
{
:service_name => 'placement_service',
:auth_name => 'placement',
:password => 'placement_password'
}
end
it { should contain_keystone_user('placement') }
it { should contain_keystone_user_role('placement@services') }
it { should contain_keystone_service('placement_service::placement') }
it { should contain_keystone_endpoint('RegionOne/placement_service::placement') }
end
context 'when disabling user configuration' do
let :params do
{
:password => 'placement_password',
:configure_user => false
}
end
it { should_not contain_keystone_user('placement') }
it { should contain_keystone_user_role('placement@services') }
it { should contain_keystone_service('placement::placement').with(
:ensure => 'present',
:description => 'Placement Service'
)}
end
context 'when disabling user and user role configuration' do
let :params do
{
:password => 'placement_password',
:configure_user => false, :configure_user => false,
:configure_user_role => false :configure_user_role => false,
} :service_description => 'Alternative Placement Service',
:service_name => 'alt_service',
:service_type => 'alt_placement',
:region => 'RegionTwo',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81' }
end end
it { should_not contain_keystone_user('placement') } it { is_expected.to contain_keystone__resource__service_identity('placement').with(
it { should_not contain_keystone_user_role('placement@services') } :configure_user => false,
:configure_user_role => false,
it { should contain_keystone_service('placement::placement').with( :configure_endpoint => false,
:ensure => 'present', :service_name => 'alt_service',
:description => 'Placement Service' :service_type => 'alt_placement',
)} :service_description => 'Alternative Placement Service',
end :region => 'RegionTwo',
:auth_name => 'alt_placement',
context 'when using ensure absent' do :password => 'placement_password',
let :params do :email => 'alt_placement@alt_localhost',
{ :tenant => 'alt_service',
:password => 'placement_password', :public_url => 'https://10.10.10.10:80',
:ensure => 'absent' :internal_url => 'http://10.10.10.11:81',
} :admin_url => 'http://10.10.10.12:81',
end ) }
it { should contain_keystone__resource__service_identity('placement').with_ensure('absent') }
end end
end end