openstack
/
puppet-qdr
Code Issues Proposed changes

Fix type validation of qdr::listener_port 

Currently qdr::listener_port is set to a string by default and triggers
the following warning.

validate_legacy(validate_re) expects an Integer value, got String at
["/etc/puppetlabs/code/modules/qdr/manifests/init.pp", 198]:

This change fixes type validation logic about the parameter to get rid
of the warning.

Change-Id: I78203816bd91c8efe0673045fdc6956c83044053
This commit is contained in:
Takashi Kajinami 2021-08-29 08:12:10 +09:00
parent 9a82468f74
commit 9799862f81
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
manifests/init.pp
View File

@ -195,9 +195,12 @@ class qdr(
['^(standalone$|edge$|interior$)'])
validate_legacy(String, 'validate_string', $router_id)
validate_legacy(String, 'validate_string', $listener_addr)
validate_legacy(Integer, 'validate_re', $listener_port, ['\d+'])
validate_legacy(String, 'validate_string', $listener_sasl_mech)
if ! $listener_port =~ Stdlib::Compat::Integer {
validate_legacy(String, 'validate_re', $listener_port, ['\d+'])
}
$listener_auth_peer_bool = qdr::fixTruthy($listener_auth_peer)
$listener_require_encrypt_bool = qdr::fixTruthy($listener_require_encrypt)
$listener_require_ssl_bool = qdr::fixTruthy($listener_require_ssl)