Commit Graph

55 Commits (master)

Author SHA1 Message Date
Takashi Kajinami dfaa45af6e replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

This also adds type definitions for all parameters, to avoid errors
in template rendering or rendering invalid content.

Change-Id: I5eedfe2ec4a192234226740ec410dd31cf941e85
2023-09-04 13:47:06 +09:00
Takashi Kajinami b50afaee83 Fix wrong default value of qdr::router_worker_threads
The default should match processor counts instead of os_worker fact.
This module does not depend on openstacklib so we should not use
the fact provided that module.

Closes-Bug: #2023371
Change-Id: I534f29d75046a854a54b4c07cfb5757bfd39dd92
2023-08-02 14:04:04 +09:00
Zuul d78a346455 Merge "Replace deprecated Stdlib::Compat::Integer" 2023-05-31 15:24:50 +00:00
Takashi Kajinami 78d889e7c3 Replace deprecated Stdlib::Compat::Integer
All Stdlib::Compat::* types were removed in the latest stdlib[1].

[1] fcbd4267fd

Change-Id: Ie8532960aad01054ee5e255df61d1d0970e8a566
2023-05-31 12:42:09 +09:00
Takashi Kajinami d729093de0 Revert "Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path"
This reverts commit 9a7a6c3f43.

Reason for revert:
Stdlib::Absolutepath has never been deprecated, but
Stdlib::Compat::Absolute_path was deprecated. The latest stdlib
removed all Stdlib::Compat::* types[1].

[1] fcbd4267fd

Change-Id: I657c74d476b34fbb3e15229f48440dbbdbde8402
2023-05-31 03:39:54 +00:00
Joel Capitao 9a7a6c3f43 Replace Stdlib::Absolutepath by Stdlib::Compat::Absolute_path
The Stdlib::Absolutepath which was deprecated 4 years ago is
now removed since [1]. We replace it by the
Stdlib::Compat::Absolute_path [2] data type which contains the
same functions "is_absolute_path" and "validate_absolute_path".


Change-Id: Iec51d93025702a40b2f2be45a655eded125f1ab5
2023-05-05 10:12:21 +02:00
Takashi Kajinami 930cdd9783 Fix ignored qdr::listener_* parameters
Closes-Bug: #2012200
Change-Id: If8ec5f0e698f1b198304cec45081cb6d0bbe1676
2023-03-20 12:40:58 +09:00
Takashi Kajinami 537fc7c64d Enforce boolean values
Usage of truthy strings were deprecated a while ago[1]. Let's enforce
boolean values to simplify the logic.

[1] 171b6d172d

Change-Id: Ic907c99d6a956a9a168200cf61a4b211fe582d07
2023-03-17 14:57:27 +09:00
Takashi Kajinami 080edaea9e Remove logic for CentOS <= 7
... because that old version is no longer supported.

Change-Id: Ia8adfcf0f41627fec8e8dc4db67b36deecb769cb
2023-03-02 12:55:38 +09:00
Takashi Kajinami 31675bb6da Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

Change-Id: I8c6cbf3801edac54098f0a4de51109e6cbf03913
2023-03-02 12:54:49 +09:00
Takashi Kajinami 9799862f81 Fix type validation of qdr::listener_port
Currently qdr::listener_port is set to a string by default and triggers
the following warning.

validate_legacy(validate_re) expects an Integer value, got String at
["/etc/puppetlabs/code/modules/qdr/manifests/init.pp", 198]:

This change fixes type validation logic about the parameter to get rid
of the warning.

Change-Id: I78203816bd91c8efe0673045fdc6956c83044053
2021-08-29 09:01:42 +09:00
Zuul 0d9350d6e3 Merge "Drop Fedora support" 2021-06-28 09:01:55 +00:00
Takashi Kajinami 94a6b90a6d Drop Fedora support
Fedora support is never tested, and has been unmaintained for a while.
Because we don't expect any actual user using OpenStack on Fedora, this
change drops support for Fedora directly.

Change-Id: Id0f6bf8e1e1f622c957477a8895ac99584176f33
2021-06-15 16:55:54 +09:00
Takashi Kajinami 6f47b4c6a5 Fix lint errors with the latest lint packages
This change fixes the following lint errors discovered since we removed
pin of lint packages.

manifests/init.pp:218:WARNING: absolute class name reference
manifests/init.pp:219:WARNING: absolute class name reference
manifests/init.pp:220:WARNING: absolute class name reference

Change-Id: I13332d9c2a91d2b10494ec9f77652cc564d454b2
2021-05-27 18:18:33 +09:00
Chris Sibbitt 171b6d172d Deprecate truthy strings
Change-Id: I58361fff9fc490255240a3bb1f2bede4e1906b5d
2021-03-24 13:32:44 -04:00
Chris Sibbitt 43f80842c7 Adjust yes/no to be booleans
Change-Id: I28b76ae92c5a9ca773d0297483bd1f550b094e41
2021-03-01 13:42:51 -05:00
Tobias Urdin 7a6e6677b9 Convert all class usage to relative names
Change-Id: I1bc6b1f77740236919d3a21506aceee6a5d817d4
2019-12-08 23:19:52 +01:00
Zuul b8236cf5ec Merge "Provide more useful fail message" 2019-04-25 15:14:53 +00:00
Nagasai Vinaykumar Kapalavai 72d7a8dea6 "Update Qdr service version to 1.5.0"
This reverts commit df921edc57.
and updated to version 1.5.0 as that is available from packaging

Change-Id: I6141f7b69b1ec08ca13ca01c036a8e5c7aca87bb
2019-03-08 14:55:13 -05:00
Nagasai Vinaykumar Kapalavai df921edc57 Update Qdr service version
Update Qpid dispatch router
version to include edge mode.

Change-Id: I44d2bf0c1c717cb9895e605f6900e5135ec7fc66
2019-03-04 14:24:46 -05:00
Zuul d99d27f08d Merge "Use validate_legacy" 2019-02-25 17:29:51 +00:00
Tobias Urdin fd5b7c4ec6 Use validate_legacy
This changes all the puppet 3 validate_* functions
to use the validate_legacy function.

The validate_legacy function has been available since
about three years but require Puppet >= 4.4.0 and since
there is Puppet 4.10.12 as latest we should assume people
are running a fairly new Puppet 4 version.

This is the first step to then remove all validate function
calls and use proper types for parameter as described in spec [1].


Change-Id: Ie05d6e6222224470450637f16691f933085e6520
2019-02-23 22:44:46 +01:00
yatin 08d62670e7 Use 'dnf' provider for Fedora and RedHat > 7
Change-Id: Ia70639a6f794bd86d247050ea2bd5292e826cd19
2018-12-19 15:10:49 +05:30
Nagasai Vinaykumar Kapalavai b6228764a1 Changes to include broker connector configuration.
Changes were done to include multiple ssl_profiles
which can be used to by both listeners and connectors.
Also autolink configuration is added to enable
external broker connection.

Change-Id: Ib3090c01bfdcb60168dd1c6db23c520a103c051e
2018-11-26 17:24:28 +00:00
Nagasai Vinaykumar Kapalavai c2b636fb01 Revert "Add a broker connector configuration"
This reverts commit b87634ca57.
The above commit contains overlapping of variables,
we need to keep puppet modules as general as possible and add
the customisations at the template level.

Closes-Bug: #1804254
Change-Id: I0e87eb9a086dcf187e2b77f8a129a63f2e6ddd6e
2018-11-20 15:35:05 +00:00
Nagasai Vinaykumar Kapalavai b87634ca57 Add a broker connector configuration
Update to add connector configuration information
so that data can be dispatched to an intermediate broker

Change-Id: I214c984b19b47c6447c8912d8d736af179b1f34f
2018-11-02 16:15:43 +00:00
zhulingjie f07ef2180f Provide more useful fail message
Change-Id: Iddbe3c238d430d340d2abdc7b36f1bcfef19644a
Closes-Bug: #1792718
2018-09-13 20:27:30 -04:00
Martin Mágr af35d35c5f Support edge mode
This patch enables to set QDR to edge mode. For more info please check:

Change-Id: If9e3658d304c3071f53ecb1c42796d2603875fcd
2018-06-06 22:31:04 +02:00
Jenkins 24e7b93f8d Merge "Remove extra spaces" 2017-07-31 17:48:25 +00:00
Andrew Smith 537c1b23d5 Update ensurable for qdr types and directory
These updates were found to be necessary for puppet-opentstack-integration
scenario to run succesfully.

This patch:
*pass block to ensurable for qdr types
*add routerd log directory

Change-Id: If06b558ac6c1b2a926b10de389e6af23cec84d28
2017-07-28 13:23:22 -04:00
ZhongShengping f4ca69af3d Remove extra spaces
Change-Id: Id4f859029b4377a61eee825dbd96ea518e988ca5
2017-07-27 08:36:59 +08:00
Andrew Smith a48d12200a Change default log location for qdrouterd service
Change-Id: Ia3bc189b3ddf27db9325dffada6d36adc1aab463
Closes-Bug: 1706091
2017-07-24 10:48:20 -04:00
Carlos Camacho 95c0eb47b2 Fix lint issues to upgrade to puppet-lint 2.3
2017-07-20 14:46:22.341413 | manifests/init.pp:204:WARNING: arrow should be on the right operand's line
2017-07-20 14:46:22.341547 | manifests/init.pp:205:WARNING: arrow should be on the right operand's line

Change-Id: I26779b1c3d6095552bcbc130b363a4013b7b568f
2017-07-20 20:44:42 +02:00
John Eckersberg 359729340b Add external listener, connector and address configuration
Change-Id: Iffdda83411ff508dc07540ea437e2ccb1f06e8c6
2017-05-24 10:48:01 -04:00
Andrew Smith df0e57b4d6 Update router_worker_threads to os_workers
This patch:
* re-factors install
* configures params based on osfamily
* Adds tests to ensure config updates
* Updates template for change in conf schema
* Adds ssl profile to the configuration

Change-Id: I92f466b46da11d8e087e6d6d9532326fce33e47c
2017-01-10 08:51:01 -05:00
Emilien Macchi f8a02e887f Fix lint job
Fix some lint issues.

Change-Id: I9e852a8b054221036cf559138170fec5e7c2f702
2016-11-25 11:57:26 -05:00
Alex Schultz 75bb0b5c3e Fix puppet-qdr testing
This change updates the puppet-qdr module to leverage the
puppet-openstack_spec_helper for unit testing and common dependency
management for spec tests. Additionally this change fixes the lint
issues with the module.

Change-Id: I62d6b60712e237a8b4daf654879a4f1912fb9ec6
2016-10-13 15:30:05 -06:00
Andrew Smith 6527742aed Fix typo and transposition 2016-07-14 14:40:39 -04:00
Andrew Smith b374043ed1 Add address type and refactor parameters 2016-07-14 12:39:52 -04:00
Andrew Smith 911e05eab4 Schema updates and spec tests 2016-06-07 10:35:52 -04:00
Andrew Smith bda4c1a6f1 fix check on threads 2016-04-15 15:16:15 -04:00
Andrew Smith ba869b9570 Added basic rspec tests 2016-04-15 14:58:07 -04:00
Andrew Smith ca199fd737 set default ssl paths 2016-04-14 11:36:50 -04:00
Andrew Smith 8704500c21 Add LICENSE file 2016-04-14 08:44:01 -04:00
Andrew Smith 1495562f9e Added ssl profile to template 2016-04-07 16:36:53 -04:00
Andrew Smith a4d1bb19a6 Fixed type for debian service name 2016-03-18 13:32:59 -04:00
Andrew Smith 003be79394 Some cleanup and refactoring 2016-03-18 13:10:23 -04:00
Andrew Smith c1c3e174bd missing sasl install for debian 2016-03-18 11:37:54 -04:00
Andrew Smith 9b0c69085d Ensure service home directory for sasl to create db 2016-03-18 10:53:50 -04:00
Andrew Smith 3b7668cc8d Fixed package ensure 2016-03-18 10:06:33 -04:00