Remove duplicate params and drop mock

This change removes the duplicate database_max_retries parameter from
the sahara class.

mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636

Change-Id: I0a3e57c8576e1451be5b0c039ce4f864339d4b5d
Closes-Bug: #1537251

Gemfile

@@ -14,7 +14,6 @@ group :development, :test do
   gem 'puppet-lint-variable_contains_upcase', :require => 'false'
   gem 'puppet-lint-numericvariable',          :require => 'false'
   gem 'json',                                 :require => 'false'
-  gem 'webmock',                              :require => 'false'
   gem 'puppet-openstack_spec_helper',
       :git => 'https://git.openstack.org/openstack/puppet-openstack_spec_helper',
       :require => false

manifests/init.pp

@@ -305,7 +305,6 @@ class sahara(
   $cert_file               = $::os_service_default,
   $key_file                = $::os_service_default,
   $database_connection     = undef,
-  $database_max_retries    = undef,
   $database_idle_timeout   = undef,
   $database_min_pool_size  = undef,
   $database_max_pool_size  = undef,

spec/spec_helper.rb

@@ -1,6 +1,5 @@
 require 'puppetlabs_spec_helper/module_spec_helper'
 require 'shared_examples'
-require 'webmock/rspec'
 
 require 'puppet-openstack_spec_helper/defaults'
 require 'rspec-puppet-facts'