openstack
/
puppet-sahara
Code Issues Proposed changes

Do not validate database_connection format 

Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.

Change-Id: I9de89d533921dc62c722f71624c27d7095a21654
This commit is contained in:
Takashi Kajinami 2020-08-31 17:56:36 +09:00
parent bd0ded35fa
commit b55991b5ec
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/db.pp
View File

@ -78,9 +78,6 @@ class sahara::db (
$database_retry_interval_real = pick($::sahara::database_retry_interval, $database_retry_interval)
$database_max_overflow_real = pick($::sahara::database_max_overflow, $database_max_overflow)
validate_legacy(Oslo::Dbconn, 'validate_re', $database_connection_real,
['^(mysql(\+pymysql)?|postgresql):\/\/(\S+:\S+@\S+\/\S+)?'])
oslo::db { 'sahara_config':
db_max_retries => $database_db_max_retries,
connection => $database_connection_real,