From 153fe8570bdde73ebead70ba4d45c05cdb9d0ab7 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Mon, 16 Mar 2020 21:34:11 +0900 Subject: [PATCH] Add missing unit tests for s3api middleware Add missing unit tests for s3api middleware, including tests to override parameters. Change-Id: I3b507d14202e92095d7e9a4e8a6b1abf4a52a2f5 --- spec/classes/swift_proxy_s3api_spec.rb | 29 +++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/spec/classes/swift_proxy_s3api_spec.rb b/spec/classes/swift_proxy_s3api_spec.rb index 9fe899d2..0324b6e2 100644 --- a/spec/classes/swift_proxy_s3api_spec.rb +++ b/spec/classes/swift_proxy_s3api_spec.rb @@ -1,10 +1,33 @@ require 'spec_helper' describe 'swift::proxy::s3api' do + + let :params do + {} + end + shared_examples 'swift::proxy::s3api' do - it { is_expected.to contain_swift_proxy_config('filter:s3api/use').with_value('egg:swift#s3api') } - it { is_expected.to contain_swift_proxy_config('filter:s3api/auth_pipeline_check').with_value('false') } - it { is_expected.to contain_swift_proxy_config('filter:s3api/max_upload_part_num').with_value('1000') } + context 'with default parameters' do + it 'configures with default' do + is_expected.to contain_swift_proxy_config('filter:s3api/use').with_value('egg:swift#s3api') + is_expected.to contain_swift_proxy_config('filter:s3api/auth_pipeline_check').with_value('false') + is_expected.to contain_swift_proxy_config('filter:s3api/max_upload_part_num').with_value('1000') + end + end + + context 'with overriding parameters' do + before do + params.merge!({ + :auth_pipeline_check => true, + :max_upload_part_num => '2000' + }) + end + it 'configures with overridden parameters' do + is_expected.to contain_swift_proxy_config('filter:s3api/use').with_value('egg:swift#s3api') + is_expected.to contain_swift_proxy_config('filter:s3api/auth_pipeline_check').with_value('true') + is_expected.to contain_swift_proxy_config('filter:s3api/max_upload_part_num').with_value('2000') + end + end end on_supported_os({