openstack/puppet-swift
Code Issues Proposed changes

Update default value of [filter:slo] max_manifest_size

Browse Source 
Default value of [filter:slo] max_manifest_size was changed in swift[1]
but puppet-swift still hard-codes the old default.
This change updates the default value to use the consistent value.

[1] 11bf9e45884aa5122e76a97cf62062d7b0bdfe54

Change-Id: Iba68f63dcf5dc401cbbf2d396530a66157ad8fce
This commit is contained in:
Takashi Kajinami
2021-12-19 23:45:05 +09:00
parent 0ef85fafbb
commit 7017388604
3 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/proxy/slo.pp
View File

@@ -13,7 +13,7 @@
#
# [*max_manifest_size*]
# (Optional) Max manifest size.
# Defaults to 2097152.
# Defaults to 8388608.
#
# [*rate_limit_under_size*]
# (Optional) Rate limiting applies only to segments smaller than this size.
@@ -69,7 +69,7 @@
#
class swift::proxy::slo (
$max_manifest_segments = '1000',
$max_manifest_size = '2097152',
$max_manifest_size = '8388608',
$rate_limit_under_size = $::os_service_default,
$rate_limit_after_segment = '10',
$rate_limit_segments_per_sec = '1',

5
releasenotes/notes/update-default-max_manifst_size-1077b1abd8813d7f.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
upgrade:
- |
Default value of ``swift::proxy::slo::max_manifest_size`` has been changed
from ``2097152`` to ``8388608``, following the change in swift itself.

2
spec/classes/swift_proxy_slo_spec.rb
View File

@@ -5,7 +5,7 @@ describe 'swift::proxy::slo' do
describe "when using default parameters" do
it { is_expected.to contain_swift_proxy_config('filter:slo/use').with_value('egg:swift#slo') }
it { is_expected.to contain_swift_proxy_config('filter:slo/max_manifest_segments').with_value('1000') }
it { is_expected.to contain_swift_proxy_config('filter:slo/max_manifest_size').with_value('2097152') }
it { is_expected.to contain_swift_proxy_config('filter:slo/max_manifest_size').with_value('8388608') }
it { is_expected.to contain_swift_proxy_config('filter:slo/rate_limit_under_size').with_value('<SERVICE DEFAULT>') }
it { is_expected.to contain_swift_proxy_config('filter:slo/rate_limit_after_segment').with_value('10') }
it { is_expected.to contain_swift_proxy_config('filter:slo/rate_limit_segments_per_sec').with_value('1') }