openstack/puppet-swift
Code Issues Proposed changes

Do not hard-code default of [swift-constraints] max_header_size

Browse Source 
... and use the service default instead, to avoid additional effort
to maintain consistent default.

This also removes the recommendation described in the parameter
description which is not present in Swift documentation.

Change-Id: I5a42240dd8d5b278e2b575d37ba2e62c42ae53e0
This commit is contained in:
Takashi Kajinami
2022-08-22 16:25:14 +09:00
parent 0cce118d52
commit 7d1956eadc
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/init.pp
View File

@@ -29,8 +29,8 @@
#
# [*max_header_size*]
# (Optional) Max HTTP header size for incoming requests for all swift
# services. Recommended size is 32768 for PKI keystone tokens.
# Defaults to 8192
# services.
# Defaults to $::os_service_default
#
# == Dependencies
#
@@ -48,7 +48,7 @@ class swift(
$swift_hash_path_suffix = $::os_service_default,
$swift_hash_path_prefix = $::os_service_default,
$package_ensure = 'present',
$max_header_size = 8192,
$max_header_size = $::os_service_default,
) {
include swift::deps

6
spec/classes/swift_spec.rb
View File

@@ -25,7 +25,7 @@ describe 'swift' do
is_expected.to contain_swift_config(
'swift-hash/swift_hash_path_prefix').with_value('<SERVICE DEFAULT>')
is_expected.to contain_swift_config(
'swift-constraints/max_header_size').with_value(8192)
'swift-constraints/max_header_size').with_value('<SERVICE DEFAULT>')
end
it {
@@ -47,12 +47,12 @@ describe 'swift' do
context 'with max_header_size' do
before do
params.merge!({:max_header_size => 16384})
params.merge!({:max_header_size => 8192})
end
it 'should configure swift.conf' do
is_expected.to contain_swift_config(
'swift-constraints/max_header_size').with_value(16384)
'swift-constraints/max_header_size').with_value(8192)
end
end