openstack/puppet-swift
Code Issues Proposed changes

bulk: Reduce default yield_frequency

Browse Source 
... following the change in swift[1].

[1] 892c226ce57a8367db46409fe35257ae41c558f7

Related-Bug: #1270246
Change-Id: Id6d43eed1df1f67fee50e62d4e27bb9d335f56ff
This commit is contained in:
Takashi Kajinami
2021-12-20 10:21:53 +09:00
parent 1ef0107008
commit a9eb3272f0
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/proxy/bulk.pp
View File

@@ -35,13 +35,13 @@
# [*yield_frequency*] # [*yield_frequency*]
# The frequency the server will spit out an ' ' to keep the connection alive # The frequency the server will spit out an ' ' to keep the connection alive
# while its processing the request. # while its processing the request.
# Default to 60. # Default to 10.
# #
class swift::proxy::bulk( class swift::proxy::bulk(
$max_containers_per_extraction = '10000', $max_containers_per_extraction = '10000',
$max_failed_extractions = '1000', $max_failed_extractions = '1000',
$max_deletes_per_request = '10000', $max_deletes_per_request = '10000',
$yield_frequency = '60', $yield_frequency = '10',
) { ) {
include swift::deps include swift::deps

5
releasenotes/notes/bulk-yield_frequency-2ad6dc679ef17452.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
upgrade:
- |
Default value of ``swift::proxy::bulk`` has been changed from ``60`` to
``10``, which is consistent with the service default.

6
spec/classes/swift_proxy_bulk_spec.rb
View File

@@ -27,7 +27,7 @@ describe 'swift::proxy::bulk' do
it { is_expected.to contain_swift_proxy_config('filter:bulk/max_containers_per_extraction').with_value('10000') } it { is_expected.to contain_swift_proxy_config('filter:bulk/max_containers_per_extraction').with_value('10000') }
it { is_expected.to contain_swift_proxy_config('filter:bulk/max_failed_extractions').with_value('1000') } it { is_expected.to contain_swift_proxy_config('filter:bulk/max_failed_extractions').with_value('1000') }
it { is_expected.to contain_swift_proxy_config('filter:bulk/max_deletes_per_request').with_value('10000') } it { is_expected.to contain_swift_proxy_config('filter:bulk/max_deletes_per_request').with_value('10000') }
it { is_expected.to contain_swift_proxy_config('filter:bulk/yield_frequency').with_value('60') } it { is_expected.to contain_swift_proxy_config('filter:bulk/yield_frequency').with_value('10') }
end end
describe "when overriding default parameters" do describe "when overriding default parameters" do
@@ -36,7 +36,7 @@ describe 'swift::proxy::bulk' do
:max_containers_per_extraction => 5000, :max_containers_per_extraction => 5000,
:max_failed_extractions => 500, :max_failed_extractions => 500,
:max_deletes_per_request => 5000, :max_deletes_per_request => 5000,
:yield_frequency => 10 :yield_frequency => 60,
} }
end end
@@ -44,7 +44,7 @@ describe 'swift::proxy::bulk' do
it { is_expected.to contain_swift_proxy_config('filter:bulk/max_containers_per_extraction').with_value('5000') } it { is_expected.to contain_swift_proxy_config('filter:bulk/max_containers_per_extraction').with_value('5000') }
it { is_expected.to contain_swift_proxy_config('filter:bulk/max_failed_extractions').with_value('500') } it { is_expected.to contain_swift_proxy_config('filter:bulk/max_failed_extractions').with_value('500') }
it { is_expected.to contain_swift_proxy_config('filter:bulk/max_deletes_per_request').with_value('5000') } it { is_expected.to contain_swift_proxy_config('filter:bulk/max_deletes_per_request').with_value('5000') }
it { is_expected.to contain_swift_proxy_config('filter:bulk/yield_frequency').with_value('10') } it { is_expected.to contain_swift_proxy_config('filter:bulk/yield_frequency').with_value('60') }
end end
end end