openstack/puppet-swift
Code Issues Proposed changes

Cleanup, Improve coverage of swift::keystone::auth spec tests

Browse Source 
Refactor with shared examples, improves coverage with 12 additional
tests.

Change-Id: Ie686af051f11941a88ea479b1d9187560f8140bb
This commit is contained in:
David Moreau Simard 2014-02-03 12:27:54 -05:00
parent f8fbd8addf
commit c26875a010
2 changed files with 101 additions and 128 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

225
spec/classes/swift_keystone_auth_spec.rb
View File

@ -2,153 +2,122 @@ require 'spec_helper'
describe 'swift::keystone::auth' do
describe 'with default class parameters' do
let :params do
{ }
end
it { should contain_keystone_user('swift').with(
let :default_params do
{
:auth_name => 'swift',
:password => 'swift_password',
:port => '8080',
:tenant => 'services',
:email => 'swift@localhost',
:region => 'RegionOne',
:operator_roles => ['admin', 'SwiftOperator'],
:public_protocol => 'http',
:public_address => '127.0.0.1',
:admin_protocol => 'http',
:admin_address => '127.0.0.1',
:internal_protocol => 'http',
:internal_address => '127.0.0.1',
}
end
shared_examples_for 'swift keystone auth' do
context 'with default class parameters' do
it_configures 'keystone auth configuration'
['admin', 'SwiftOperator'].each do |role_name|
it { should contain_keystone_role(role_name).with_ensure('present') }
end
end
context 'with custom class parameters' do
before do
params.merge!({
:auth_name => 'object_store',
:password => 'passw0rd',
:port => '443',
:tenant => 'admin',
:email => 'object_store@localhost',
:region => 'RegionTwo',
:operator_roles => ['admin', 'SwiftOperator', 'Gopher'],
:public_protocol => 'https',
:public_address => 'public.example.org',
:public_port => '443',
:admin_protocol => 'https',
:admin_address => 'admin.example.org',
:internal_protocol => 'https',
:internal_address => 'internal.example.org',
})
end
it_configures 'keystone auth configuration'
['admin', 'SwiftOperator', 'Gopher'].each do |role_name|
it { should contain_keystone_role(role_name).with_ensure('present') }
end
end
end
shared_examples_for 'keystone auth configuration' do
let :p do
default_params.merge( params )
end
it { should contain_keystone_user(p[:auth_name]).with(
:ensure => 'present',
:password => 'swift_password'
) }
it { should contain_keystone_user_role('swift@services').with(
:ensure => 'present',
:roles => 'admin',
:require => 'Keystone_user[swift]'
:password => p[:password],
:email => p[:email]
)}
it { should contain_keystone_service('swift').with(
it { should contain_keystone_user_role("#{p[:auth_name]}@#{p[:tenant]}").with(
:ensure => 'present',
:roles => 'admin',
:require => "Keystone_user[#{p[:auth_name]}]"
)}
it { should contain_keystone_service(p[:auth_name]).with(
:ensure => 'present',
:type => 'object-store',
:description => 'Openstack Object-Store Service'
) }
)}
it { should contain_keystone_endpoint('RegionOne/swift').with(
it { should contain_keystone_endpoint("#{p[:region]}/#{p[:auth_name]}").with(
:ensure => 'present',
:public_url => "http://127.0.0.1:8080/v1/AUTH_%(tenant_id)s",
:admin_url => "http://127.0.0.1:8080/",
:internal_url => "http://127.0.0.1:8080/v1/AUTH_%(tenant_id)s"
) }
:public_url => "#{p[:public_protocol]}://#{p[:public_address]}:#{p[:port]}/v1/AUTH_%(tenant_id)s",
:admin_url => "#{p[:admin_protocol]}://#{p[:admin_address]}:#{p[:port]}/",
:internal_url => "#{p[:internal_protocol]}://#{p[:internal_address]}:#{p[:port]}/v1/AUTH_%(tenant_id)s"
)}
it { should contain_keystone_service('swift_s3').with(
:ensure => 'present',
:type => 's3',
:description => 'Openstack S3 Service'
) }
it { should contain_keystone_service("#{p[:auth_name]}_s3").with(
:ensure => 'present',
:type => 's3',
:description => 'Openstack S3 Service'
)}
it { should contain_keystone_endpoint('RegionOne/swift_s3').with(
it { should contain_keystone_endpoint("#{p[:region]}/#{p[:auth_name]}_s3").with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:8080',
:admin_url => 'http://127.0.0.1:8080',
:internal_url => 'http://127.0.0.1:8080'
) }
['admin', 'SwiftOperator'].each do |role_name|
it { should contain_keystone_role(role_name).with_ensure('present') }
end
:public_url => "#{p[:public_protocol]}://#{p[:public_address]}:#{p[:port]}",
:admin_url => "#{p[:admin_protocol]}://#{p[:admin_address]}:#{p[:port]}",
:internal_url => "#{p[:internal_protocol]}://#{p[:internal_address]}:#{p[:port]}"
)}
end
describe 'overriding public_port public_protocol, admin_protocol and internal_protocol' do
let :params do
{
:port => '443',
:public_protocol => 'https',
:admin_protocol => 'https',
:internal_protocol => 'https',
}
context 'on Debian platforms' do
let :facts do
{ :osfamily => 'Debian' }
end
it { should contain_keystone_endpoint('RegionOne/swift').with(
:ensure => 'present',
:public_url => "https://127.0.0.1:443/v1/AUTH_%(tenant_id)s",
:admin_url => "https://127.0.0.1:443/",
:internal_url => "https://127.0.0.1:443/v1/AUTH_%(tenant_id)s"
) }
it { should contain_keystone_endpoint('RegionOne/swift_s3').with(
:ensure => 'present',
:public_url => 'https://127.0.0.1:443',
:admin_url => 'https://127.0.0.1:443',
:internal_url => 'https://127.0.0.1:443'
) }
it_configures 'swift keystone auth'
end
describe 'when overriding public_port, public address, admin_address and internal_address' do
let :params do
{
:public_port => '80',
:public_address => '10.10.10.10',
:admin_address => '10.10.10.2',
:internal_address => '127.0.0.1'
}
context 'on RedHat platforms' do
let :facts do
{ :osfamily => 'RedHat' }
end
it { should contain_keystone_endpoint('RegionOne/swift').with(
:ensure => 'present',
:public_url => "http://10.10.10.10:80/v1/AUTH_%(tenant_id)s",
:admin_url => "http://10.10.10.2:8080/",
:internal_url => "http://127.0.0.1:8080/v1/AUTH_%(tenant_id)s"
) }
it { should contain_keystone_endpoint('RegionOne/swift_s3').with(
:ensure => 'present',
:public_url => 'http://10.10.10.10:80',
:admin_url => 'http://10.10.10.2:8080',
:internal_url => 'http://127.0.0.1:8080'
) }
end
describe 'when overriding password' do
let :params do
{
:password => 'foo'
}
end
it { should contain_keystone_user('swift').with(
:ensure => 'present',
:password => 'foo'
) }
end
describe 'when overriding auth name' do
let :params do
{
:auth_name => 'swifty'
}
end
it { should contain_keystone_user('swifty') }
it { should contain_keystone_user_role('swifty@services') }
it { should contain_keystone_service('swifty') }
it { should contain_keystone_endpoint('RegionOne/swifty') }
it { should contain_keystone_service('swifty_s3') }
it { should contain_keystone_endpoint('RegionOne/swifty_s3') }
end
describe 'when overriding operator_roles' do
let :params do
{
:operator_roles => 'foo',
}
end
it { should contain_keystone_role('foo').with(
:ensure => 'present'
) }
it_configures 'swift keystone auth'
end
end

4
spec/spec_helper.rb
View File

@ -1 +1,5 @@
require 'puppetlabs_spec_helper/module_spec_helper'
RSpec.configure do |c|
c.alias_it_should_behave_like_to :it_configures, 'configures'
end