openstack/puppet-swift
Code Issues Proposed changes

Merge "Validate ensure parameter for package resources"

Browse Source
This commit is contained in:
Zuul
2025-09-25 17:28:34 +00:00
committed by Gerrit Code Review
parent d2feff8ac9 6d3abccd29
commit d2bb6e9a24
11 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/client.pp
View File

@@ -9,7 +9,7 @@
# Defaults to 'present'. # Defaults to 'present'.
# #
class swift::client ( class swift::client (
$ensure = 'present', Stdlib::Ensure::Package $ensure = 'present',
) { ) {
include swift::deps include swift::deps
include swift::params include swift::params

2
manifests/containerreconciler.pp
View File

@@ -115,7 +115,7 @@
class swift::containerreconciler ( class swift::containerreconciler (
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Swift::Pipeline $pipeline = ['catch_errors', 'proxy-logging', 'cache', 'proxy-server'], Swift::Pipeline $pipeline = ['catch_errors', 'proxy-logging', 'cache', 'proxy-server'],
$interval = $facts['os_service_default'], $interval = $facts['os_service_default'],
$concurrency = $facts['os_service_default'], $concurrency = $facts['os_service_default'],

2
manifests/init.pp
View File

@@ -47,7 +47,7 @@
class swift ( class swift (
$swift_hash_path_suffix = $facts['os_service_default'], $swift_hash_path_suffix = $facts['os_service_default'],
$swift_hash_path_prefix = $facts['os_service_default'], $swift_hash_path_prefix = $facts['os_service_default'],
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Boolean $purge_config = false, Boolean $purge_config = false,
) { ) {
include swift::deps include swift::deps

2
manifests/objectexpirer.pp
View File

@@ -132,7 +132,7 @@
class swift::objectexpirer ( class swift::objectexpirer (
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Swift::Pipeline $pipeline = ['catch_errors', 'proxy-logging', 'cache', 'proxy-server'], Swift::Pipeline $pipeline = ['catch_errors', 'proxy-logging', 'cache', 'proxy-server'],
$concurrency = $facts['os_service_default'], $concurrency = $facts['os_service_default'],
$interval = $facts['os_service_default'], $interval = $facts['os_service_default'],

2
manifests/proxy.pp
View File

@@ -249,7 +249,7 @@ class swift::proxy (
$allow_open_expired = $facts['os_service_default'], $allow_open_expired = $facts['os_service_default'],
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Swift::ServiceProvider $service_provider = $swift::params::service_provider, Swift::ServiceProvider $service_provider = $swift::params::service_provider,
Boolean $purge_config = false, Boolean $purge_config = false,
) inherits swift::params { ) inherits swift::params {

2
manifests/proxy/ceilometer.pp
View File

@@ -177,7 +177,7 @@ class swift::proxy::ceilometer (
$driver = $facts['os_service_default'], $driver = $facts['os_service_default'],
$topic = $facts['os_service_default'], $topic = $facts['os_service_default'],
$control_exchange = $facts['os_service_default'], $control_exchange = $facts['os_service_default'],
$ensure = 'present', Stdlib::Ensure::Package $ensure = 'present',
$nonblocking_notify = $facts['os_service_default'], $nonblocking_notify = $facts['os_service_default'],
$ignore_projects = ['services'], $ignore_projects = ['services'],
$auth_url = 'http://127.0.0.1:5000', $auth_url = 'http://127.0.0.1:5000',

2
manifests/storage/account.pp
View File

@@ -29,7 +29,7 @@
class swift::storage::account ( class swift::storage::account (
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
String[1] $config_file_name = 'account-server.conf', String[1] $config_file_name = 'account-server.conf',
Swift::ServiceProvider $service_provider = $swift::params::service_provider Swift::ServiceProvider $service_provider = $swift::params::service_provider
) inherits swift::params { ) inherits swift::params {

2
manifests/storage/container.pp
View File

@@ -34,7 +34,7 @@
class swift::storage::container ( class swift::storage::container (
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
Array[String[1]] $allowed_sync_hosts = ['127.0.0.1'], Array[String[1]] $allowed_sync_hosts = ['127.0.0.1'],
String[1] $config_file_name = 'container-server.conf', String[1] $config_file_name = 'container-server.conf',
Swift::ServiceProvider $service_provider = $swift::params::service_provider Swift::ServiceProvider $service_provider = $swift::params::service_provider

2
manifests/storage/generic.pp
View File

@@ -37,7 +37,7 @@ define swift::storage::generic (
Swift::StorageServerType $type = $name, Swift::StorageServerType $type = $name,
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
String[1] $config_file_name = "${name}-server.conf", String[1] $config_file_name = "${name}-server.conf",
Swift::ServiceProvider $service_provider = $swift::params::service_provider Swift::ServiceProvider $service_provider = $swift::params::service_provider
) { ) {

2
manifests/storage/object.pp
View File

@@ -29,7 +29,7 @@
class swift::storage::object ( class swift::storage::object (
Boolean $manage_service = true, Boolean $manage_service = true,
Boolean $enabled = true, Boolean $enabled = true,
$package_ensure = 'present', Stdlib::Ensure::Package $package_ensure = 'present',
String[1] $config_file_name = 'object-server.conf', String[1] $config_file_name = 'object-server.conf',
Swift::ServiceProvider $service_provider = $swift::params::service_provider Swift::ServiceProvider $service_provider = $swift::params::service_provider
) inherits swift::params { ) inherits swift::params {

2
manifests/storage/policy.pp
View File

@@ -60,7 +60,7 @@
define swift::storage::policy ( define swift::storage::policy (
$policy_name, $policy_name,
$default_policy, $default_policy,
$ensure = 'present', Enum['present', 'absent'] $ensure = 'present',
$policy_aliases = undef, $policy_aliases = undef,
$policy_index = $name, $policy_index = $name,
$policy_type = 'replication', $policy_type = 'replication',