9 Commits

Author SHA1 Message Date
Sebastien Badia
f4cfe8e8e4 spec: updates for rspec-puppet 2.x and rspec 3.x
This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
in order to be prepared for rspec 3.x move.

In details:
  * Use shared_examples "a Puppet::Error" for puppet::error tests
  * Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
  * Fix spec tests for rspec-puppet 2.0.0
  * Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
  * Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
  * Remove un-used puppet-lint (name_containing_dash config)

Change-Id: I5488507176d4665895eef65ddb4b6f0fb4eda3e7
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
2015-03-24 15:22:16 +01:00
Dan Bode
b379804ca9 fix bug setting device
The device set for the storage mount point was
hard-coded to /dev/$name. This value is only
valid when no device is supplied to the storage
xfs setup.

This commit updates it to use the target_device
which is either the device that was passed, or
/dev/$name if not device is specified.
2013-01-07 11:07:20 -08:00
Sergio Rubio
0a630c3c9e swift::storage::xfs improvements
* Create $mnt_base_dir if dir does not exist (useful when not using
* loopback)
* use 'xfs_admin -l' to check for an existing XFS instead of using
* refreshonly
* device param now defaults to '' for compat reasons since we'll be
  using '/dev/' + resource title when no device is specified
* use -f flag with mkfs.xfs so we can format RAW unpartitioned devices
* Does not break interface compatibility, tests OK
2012-09-26 18:37:11 +02:00
Branan Purvine-Riley
b63a9dbe07 Merge pull request #46 from bodepd/add_loopback_mnt_param
Add loopback mnt param
2012-07-23 16:32:49 -07:00
Dan Bode
4691b3929d Add spec tests for additional loopback parameter.
This commit adds test coverage that verifies the
behavior of the loopback related class parameters.
2012-07-23 15:04:14 -07:00
Branan Purvine-Riley
eef6b12f44 Replace expect..should with expect..to 2012-07-12 15:24:03 -07:00
Branan Purvine-Riley
078cef7f9d Change contain_exec path from list to string 2012-05-08 15:52:19 -07:00
Dan Bode
4acfaeaa9d Update stoage::xfs tests
This file was accidentally checked in before
the tests works.

This commit fixes the spec tests.
2012-02-26 21:19:13 -08:00
Dan Bode
4775be3a5f Add rspec-puppet test coverage
This commit adds test coverage for almost all
swift classes and defines.

It does not quite add 100% coverage (probably
more like 85%)
2012-02-26 20:52:27 -08:00