This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
in order to be prepared for rspec 3.x move.
In details:
* Use shared_examples "a Puppet::Error" for puppet::error tests
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x)
* Fix spec tests for rspec-puppet 2.0.0
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper)
* Remove un-used puppet-lint (name_containing_dash config)
Change-Id: I5488507176d4665895eef65ddb4b6f0fb4eda3e7
Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
The device set for the storage mount point was
hard-coded to /dev/$name. This value is only
valid when no device is supplied to the storage
xfs setup.
This commit updates it to use the target_device
which is either the device that was passed, or
/dev/$name if not device is specified.
* Create $mnt_base_dir if dir does not exist (useful when not using
* loopback)
* use 'xfs_admin -l' to check for an existing XFS instead of using
* refreshonly
* device param now defaults to '' for compat reasons since we'll be
using '/dev/' + resource title when no device is specified
* use -f flag with mkfs.xfs so we can format RAW unpartitioned devices
* Does not break interface compatibility, tests OK