60ed2ee79c
Maintains full backward compatibility. Use swift_proxy_config ini provider to mange proxy-server.conf. Remove all erb templates. Move all template logic into proxy middleware classes. To purge proxy.conf of settings that are not specified set the new paramater "purge_config" to "true". Change-Id: I0a143cf812043ea0f9a008a6e5c60ec87f9a4e9a
342 lines
16 KiB
Ruby
342 lines
16 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'swift::proxy' do
|
|
|
|
describe 'without memcached being included' do
|
|
it 'should raise an error' do
|
|
expect { catalogue }.to raise_error(Puppet::Error)
|
|
end
|
|
end
|
|
|
|
# set os so memcache will not fail
|
|
let :facts do
|
|
OSDefaults.get_facts({
|
|
:operatingsystem => 'Ubuntu',
|
|
:osfamily => 'Debian',
|
|
:processorcount => 1,
|
|
})
|
|
end
|
|
|
|
describe 'with proper dependencies' do
|
|
|
|
let :pre_condition do
|
|
"class { memcached: max_memory => 1}
|
|
class { swift: swift_hash_path_suffix => string }"
|
|
end
|
|
|
|
describe 'without the proxy local network ip address being specified' do
|
|
if Puppet::Util::Package.versioncmp(Puppet.version, '4.3.0') >= 0
|
|
it_raises 'a Puppet::Error', /expects a value for parameter 'proxy_local_net_ip'/
|
|
else
|
|
it_raises 'a Puppet::Error', /Must pass proxy_local_net_ip/
|
|
end
|
|
end
|
|
|
|
describe 'when proxy_local_net_ip is set' do
|
|
|
|
let :params do
|
|
{:proxy_local_net_ip => '127.0.0.1'}
|
|
end
|
|
|
|
it 'passes purge to swift_proxy_config resource' do
|
|
is_expected.to contain_resources('swift_proxy_config').with({
|
|
:purge => false
|
|
})
|
|
end
|
|
|
|
it { is_expected.to contain_package('swift-proxy').that_requires('Anchor[swift::install::begin]')
|
|
is_expected.to contain_package('swift-proxy').that_notifies('Anchor[swift::install::end]') }
|
|
|
|
it { is_expected.to contain_service('swift-proxy-server').with(
|
|
{:ensure => 'running',
|
|
:provider => nil,
|
|
:enable => true,
|
|
:hasstatus => true,
|
|
:tag => 'swift-service',
|
|
}
|
|
)}
|
|
|
|
it { is_expected.to contain_service('swift-proxy-server').that_subscribes_to('Anchor[swift::service::begin]')}
|
|
it { is_expected.to contain_service('swift-proxy-server').that_notifies('Anchor[swift::service::end]')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/bind_port').with_value('8080')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/bind_ip').with_value('127.0.0.1')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/workers').with_value('1')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/user').with_value('swift')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_name').with_value('proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_facility').with_value('LOG_LOCAL1')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_level').with_value('INFO')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_headers').with_value('False')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_address').with_value('/dev/log')}
|
|
it { is_expected.to contain_swift_proxy_config('pipeline:main/pipeline').with_value('healthcheck cache tempauth proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/use').with_value('egg:swift#proxy')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_name').with_value('proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_facility').with_value('LOG_LOCAL1')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_level').with_value('INFO')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_address').with_value('/dev/log')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/log_handoffs').with_value('true')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/allow_account_management').with_value('true')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/account_autocreate').with_value('true')}
|
|
|
|
|
|
it { is_expected.to contain_service('swift-proxy-server').with_require(
|
|
[
|
|
'Class[Swift::Proxy::Healthcheck]',
|
|
'Class[Swift::Proxy::Cache]',
|
|
'Class[Swift::Proxy::Tempauth]'
|
|
]
|
|
)}
|
|
|
|
describe "when using swift_proxy_config resource" do
|
|
let :pre_condition do
|
|
"
|
|
class { memcached: max_memory => 1}
|
|
class { swift: swift_hash_path_suffix => string }
|
|
swift_proxy_config { 'foo/bar': value => 'foo' }
|
|
"
|
|
end
|
|
it { is_expected.to contain_swift_proxy_config('foo/bar').with_value('foo').that_notifies('Anchor[swift::config::end]')}
|
|
end
|
|
|
|
describe 'when more parameters are set' do
|
|
let :params do
|
|
{
|
|
:proxy_local_net_ip => '10.0.0.2',
|
|
:port => '80',
|
|
:workers => 3,
|
|
:pipeline => ['swauth', 'proxy-server'],
|
|
:allow_account_management => false,
|
|
:account_autocreate => false,
|
|
:log_level => 'DEBUG',
|
|
:log_name => 'swift-proxy-server',
|
|
:read_affinity => 'r1z1=100, r1=200',
|
|
:write_affinity => 'r1',
|
|
:write_affinity_node_count => '2 * replicas',
|
|
:node_timeout => '20',
|
|
:cors_allow_origin => 'http://foo.bar:1234,https://foo.bar',
|
|
}
|
|
end
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/bind_port').with_value('80')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/bind_ip').with_value('10.0.0.2')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/workers').with_value('3')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/user').with_value('swift')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_name').with_value('swift-proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_facility').with_value('LOG_LOCAL1')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_level').with_value('DEBUG')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_headers').with_value('False')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_address').with_value('/dev/log')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/cors_allow_origin').with_value('http://foo.bar:1234,https://foo.bar')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/strict_cors_mode').with_value('true')}
|
|
it { is_expected.to contain_swift_proxy_config('pipeline:main/pipeline').with_value('swauth proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/use').with_value('egg:swift#proxy')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_name').with_value('swift-proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_facility').with_value('LOG_LOCAL1')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_level').with_value('DEBUG')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_address').with_value('/dev/log')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/log_handoffs').with_value('true')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/allow_account_management').with_value('false')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/account_autocreate').with_value('false')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/sorting_method').with_value('affinity')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/read_affinity').with_value('r1z1=100, r1=200')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/write_affinity').with_value('r1')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/write_affinity_node_count').with_value('2 * replicas')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/node_timeout').with_value('20')}
|
|
end
|
|
describe "when log udp port is set" do
|
|
context 'and log_udp_host is not set' do
|
|
let :params do
|
|
{
|
|
:proxy_local_net_ip => '10.0.0.2',
|
|
:port => '80',
|
|
:workers => 3,
|
|
:pipeline => ['swauth', 'proxy-server'],
|
|
:allow_account_management => false,
|
|
:account_autocreate => false,
|
|
:log_level => 'DEBUG',
|
|
:log_name => 'swift-proxy-server',
|
|
:log_udp_port => '514',
|
|
:read_affinity => 'r1z1=100, r1=200',
|
|
:write_affinity => 'r1',
|
|
:write_affinity_node_count => '2 * replicas',
|
|
:node_timeout => '20',
|
|
:cors_allow_origin => 'http://foo.bar:1234,https://foo.bar',
|
|
}
|
|
end
|
|
it_raises 'a Puppet::Error', /log_udp_port requires log_udp_host to be set/
|
|
end
|
|
context 'and log_udp_host is set' do
|
|
let :params do
|
|
{
|
|
:proxy_local_net_ip => '10.0.0.2',
|
|
:port => '80',
|
|
:workers => 3,
|
|
:pipeline => ['swauth', 'proxy-server'],
|
|
:allow_account_management => false,
|
|
:account_autocreate => false,
|
|
:log_level => 'DEBUG',
|
|
:log_name => 'swift-proxy-server',
|
|
:log_udp_host => '127.0.0.1',
|
|
:log_udp_port => '514',
|
|
:read_affinity => 'r1z1=100, r1=200',
|
|
:write_affinity => 'r1',
|
|
:write_affinity_node_count => '2 * replicas',
|
|
:node_timeout => '20',
|
|
:cors_allow_origin => 'http://foo.bar:1234,https://foo.bar',
|
|
}
|
|
end
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/bind_port').with_value('80')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/bind_ip').with_value('10.0.0.2')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/workers').with_value('3')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/user').with_value('swift')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_name').with_value('swift-proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_facility').with_value('LOG_LOCAL1')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_level').with_value('DEBUG')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_headers').with_value('False')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_address').with_value('/dev/log')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_udp_host').with_value('127.0.0.1')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/log_udp_port').with_value('514')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/cors_allow_origin').with_value('http://foo.bar:1234,https://foo.bar')}
|
|
it { is_expected.to contain_swift_proxy_config('DEFAULT/strict_cors_mode').with_value('true')}
|
|
it { is_expected.to contain_swift_proxy_config('pipeline:main/pipeline').with_value('swauth proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/use').with_value('egg:swift#proxy')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_name').with_value('swift-proxy-server')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_facility').with_value('LOG_LOCAL1')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_level').with_value('DEBUG')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/set log_address').with_value('/dev/log')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/log_handoffs').with_value('true')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/allow_account_management').with_value('false')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/account_autocreate').with_value('false')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/sorting_method').with_value('affinity')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/read_affinity').with_value('r1z1=100, r1=200')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/write_affinity').with_value('r1')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/write_affinity_node_count').with_value('2 * replicas')}
|
|
it { is_expected.to contain_swift_proxy_config('app:proxy-server/node_timeout').with_value('20')}
|
|
end
|
|
end
|
|
|
|
describe 'when supplying bad values for parameters' do
|
|
[:account_autocreate, :allow_account_management].each do |param|
|
|
it "should fail when #{param} is not passed a boolean" do
|
|
params[param] = 'false'
|
|
expect { catalogue }.to raise_error(Puppet::Error, /is not a boolean/)
|
|
end
|
|
end
|
|
|
|
let :params do
|
|
{
|
|
:proxy_local_net_ip => '127.0.0.1',
|
|
:write_affinity_node_count => '2 * replicas'
|
|
}
|
|
end
|
|
|
|
it "should fail if write_affinity_node_count is used without write_affinity" do
|
|
expect { catalogue }.to raise_error(Puppet::Error, /write_affinity_node_count requires write_affinity/)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
shared_examples_for 'swift-proxy-server' do
|
|
let :params do
|
|
{ :proxy_local_net_ip => '127.0.0.1' }
|
|
end
|
|
|
|
[{ :enabled => true, :manage_service => true },
|
|
{ :enabled => false, :manage_service => true }].each do |param_hash|
|
|
context "when service is_expected.to be #{param_hash[:enabled] ? 'enabled' : 'disabled'}" do
|
|
before do
|
|
params.merge!(param_hash)
|
|
end
|
|
|
|
it 'configures swift-proxy-server service' do
|
|
is_expected.to contain_service('swift-proxy-server').with(
|
|
:name => platform_params['swift-proxy-server'],
|
|
:ensure => (param_hash[:manage_service] && param_hash[:enabled]) ? 'running' : 'stopped',
|
|
:enable => param_hash[:enabled],
|
|
:provider => platform_params['service_provider'],
|
|
:tag => 'swift-service',
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with disabled service managing' do
|
|
before do
|
|
params.merge!({
|
|
:manage_service => false,
|
|
:enabled => false })
|
|
end
|
|
|
|
it 'configures swift-proxy-server service' do
|
|
|
|
is_expected.to contain_service('swift-proxy-server').with(
|
|
:ensure => nil,
|
|
:name => platform_params['swift-proxy-server'],
|
|
:provider => platform_params['service_provider'],
|
|
:enable => false,
|
|
:hasstatus => true,
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'on Debian platforms' do
|
|
let :facts do
|
|
OSDefaults.get_facts({
|
|
:operatingsystem => 'Ubuntu',
|
|
:osfamily => 'Debian',
|
|
:concat_basedir => '/var/lib/puppet/concat',
|
|
})
|
|
end
|
|
|
|
let :platform_params do
|
|
{ 'swift-proxy-server' => 'swift-proxy',
|
|
'service_provider' => nil
|
|
}
|
|
end
|
|
it_configures 'swift-proxy-server'
|
|
|
|
context 'on Debian platforms using swiftinit service provider' do
|
|
before do
|
|
params.merge!({ :service_provider => 'swiftinit' })
|
|
end
|
|
|
|
let :platform_params do
|
|
{ 'swift-proxy-server' => 'swift-proxy-server',
|
|
'service_provider' => 'swiftinit'
|
|
}
|
|
end
|
|
it_configures 'swift-proxy-server'
|
|
end
|
|
end
|
|
|
|
context 'on RedHat platforms' do
|
|
let :facts do
|
|
OSDefaults.get_facts({
|
|
:osfamily => 'RedHat',
|
|
:operatingsystem => 'RedHat',
|
|
:concat_basedir => '/var/lib/puppet/concat',
|
|
})
|
|
end
|
|
|
|
let :platform_params do
|
|
{
|
|
'swift-proxy-server' => 'openstack-swift-proxy',
|
|
}
|
|
end
|
|
it_configures 'swift-proxy-server'
|
|
|
|
context 'on Redhat platforms using swiftinit service provider' do
|
|
before do
|
|
params.merge!({ :service_provider => 'swiftinit' })
|
|
end
|
|
|
|
let :platform_params do
|
|
{ 'swift-proxy-server' => 'swift-proxy-server',
|
|
'service_provider' => 'swiftinit'
|
|
}
|
|
end
|
|
it_configures 'swift-proxy-server'
|
|
end
|
|
end
|
|
end
|