From 40fcf16ba88d60920814bb3bb1d37f5017db5eed Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <kajinamit@oss.nttdata.com>
Date: Sat, 20 Apr 2024 23:25:03 +0900
Subject: [PATCH] magnum: Add manage_tests_packages

The manage_tests_packages parameter exists in the base tempest class
but the same functionality is not implemented in the separate class
for magnum-tempest-plugin.

Introduce the parameter to the magnum class so that users can disable
package management completely.

Change-Id: Id06fd565371c01d3a6c3bee0366314030d287a5f
---
 manifests/magnum.pp                             | 17 ++++++++++++-----
 ...-manage_tests_packages-bc211967cc6a3d4a.yaml |  5 +++++
 2 files changed, 17 insertions(+), 5 deletions(-)
 create mode 100644 releasenotes/notes/magnum-manage_tests_packages-bc211967cc6a3d4a.yaml

diff --git a/manifests/magnum.pp b/manifests/magnum.pp
index 386a1015..fd8e810d 100644
--- a/manifests/magnum.pp
+++ b/manifests/magnum.pp
@@ -61,6 +61,10 @@
 #   (Optional) DNS nameserver to use for ClusterTemplate
 #   Defaults to '8.8.8.8'
 #
+# [*manage_tests_packages*]
+#   (Optional) Manage the plugin package
+#   Defaults to true
+#
 class tempest::magnum (
   Stdlib::Absolutepath $tempest_config_file = '/var/lib/tempest/etc/tempest.conf',
   Boolean $provision_image                  = true,
@@ -76,6 +80,7 @@ class tempest::magnum (
   $magnum_url                               = undef,
   $copy_logs                                = true,
   $dns_nameserver                           = '8.8.8.8',
+  Boolean $manage_tests_packages            = true,
 ) {
   include tempest::params
 
@@ -109,11 +114,13 @@ class tempest::magnum (
     }
   }
 
-  if $::tempest::params::python_magnum_tests {
-    package { 'python-magnum-tests':
-      ensure => present,
-      name   => $::tempest::params::python_magnum_tests,
-      tag    => ['openstack', 'tempest-package'],
+  if $manage_tests_packages {
+    if $::tempest::params::python_magnum_tests {
+      package { 'python-magnum-tests':
+        ensure => present,
+        name   => $::tempest::params::python_magnum_tests,
+        tag    => ['openstack', 'tempest-package'],
+      }
     }
   }
 
diff --git a/releasenotes/notes/magnum-manage_tests_packages-bc211967cc6a3d4a.yaml b/releasenotes/notes/magnum-manage_tests_packages-bc211967cc6a3d4a.yaml
new file mode 100644
index 00000000..222a36b0
--- /dev/null
+++ b/releasenotes/notes/magnum-manage_tests_packages-bc211967cc6a3d4a.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    The new ``tempest::magnum::manage_tests_packages`` parameter has been
+    added.