openstack/puppet-tempest
Code Issues Proposed changes

tempest_glance_id_setter: autorequire glance_image resource

Browse Source 
... so that the resource can work without any explicit dependency
definition in manifests.

Change-Id: I8265385430afa8692ea65c5df612a2581960e881
This commit is contained in:
Takashi Kajinami 2022-02-22 01:35:46 +09:00
parent fcba2cf5fb
commit 5f375ba527
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/puppet/type/tempest_glance_id_setter.rb
View File

@ -20,6 +20,10 @@ Puppet::Type.newtype(:tempest_glance_id_setter) do
desc 'name of glance image'
end
autorequire(:glance_image) do
[self[:image_name]] if self[:image_name]
end
autorequire(:package) do
['python-openstackclient', 'python3-openstackclient']
end

2
manifests/init.pp
View File

@ -787,7 +787,6 @@ class tempest(
tempest_conf_path => $tempest_conf,
image_name => $image_name,
}
Glance_image<||> -> Tempest_glance_id_setter['image_ref']
Tempest_config<||> -> Tempest_glance_id_setter['image_ref']
Keystone_user_role<||> -> Tempest_glance_id_setter['image_ref']
} elsif ($image_name and $image_ref) or (! $image_name and ! $image_ref) {
@ -799,7 +798,6 @@ class tempest(
tempest_conf_path => $tempest_conf,
image_name => $image_name_alt,
}
Glance_image<||> -> Tempest_glance_id_setter['image_ref_alt']
Tempest_config<||> -> Tempest_glance_id_setter['image_ref_alt']
Keystone_user_role<||> -> Tempest_glance_id_setter['image_ref_alt']
} elsif ($image_name_alt and $image_ref_alt) or (! $image_name_alt and ! $image_ref_alt) {