openstack
/
puppet-tempest
Code Issues Proposed changes

Warn ineffective neutron plugin parameters 

Tests for VPNaaS, BGPVPN and Dynamic Routing are bundled in neutron
temest plugin and enabled according to the extensions parameter.
Currently the parameters in tempest class have no effect.

Also, the [service_available] l2gw option does not exist. The l2gw
tests are skipped accoring to availability of the l2-gateway
extension.

Change-Id: I156d5571510f481bd54c4c7861c18392ad36e247
This commit is contained in:
Takashi Kajinami 2023-11-11 16:17:24 +09:00
parent dbef30e09b
commit 61d8b1981c
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/init.pp
View File

@ -498,6 +498,12 @@ class tempest(
warning('The tempest_config_file parameter has been deprecated and has no effect')
}
[ 'neutron_bgpvpn_available', 'neutron_vpnaas_available', 'neutron_dr_available' ].each |$opt| {
if getvar($opt) != undef {
warning("The ${opt} parameter has no effect now. Use the neutron_api_extensions parameter instead.")
}
}
include tempest::params
include openstacklib::openstackclient
@ -653,11 +659,9 @@ class tempest(
'service_available/aodh': value => $aodh_available;
'service_available/barbican': value => $barbican_available;
'service_available/manila': value => $manila_available;
'service_available/bgpvpn': value => $neutron_bgpvpn_available;
'service_available/gnocchi': value => $gnocchi_available;
'service_available/designate': value => $designate_available;
'service_available/horizon': value => $horizon_available;
'service_available/l2gw': value => $neutron_l2gw_available;
'service_available/neutron': value => $neutron_available;
'service_available/mistral': value => $mistral_available;
'service_available/vitrage': value => $vitrage_available;

2
spec/classes/tempest_init_spec.rb
View File

@ -303,10 +303,8 @@ describe 'tempest' do
is_expected.to contain_tempest_config('service_available/heat').with(:value => false)
is_expected.to contain_tempest_config('service_available/ceilometer').with(:value => false)
is_expected.to contain_tempest_config('service_available/aodh').with(:value => false)
is_expected.to contain_tempest_config('service_available/bgpvpn').with(:value => false)
is_expected.to contain_tempest_config('service_available/gnocchi').with(:value => false)
is_expected.to contain_tempest_config('service_available/horizon').with(:value => true)
is_expected.to contain_tempest_config('service_available/l2gw').with(:value => false)
is_expected.to contain_tempest_config('service_available/neutron').with(:value => true)
is_expected.to contain_tempest_config('service_available/mistral').with(:value => false)
is_expected.to contain_tempest_config('service_available/vitrage').with(:value => false)