openstack/puppet-tempest
Code Issues Proposed changes

Merge "Update default value of attach_encrypted_volume"

Browse Source
This commit is contained in:
Zuul
2025-08-15 17:00:28 +00:00
committed by Gerrit Code Review
parent 988ad0563e 8f625d209c
commit 6df4ab2c50
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/init.pp
View File

@@ -113,7 +113,7 @@
# [*ssh_key_type*]
# Defaults to $facts['os_service_default']
# [*attach_encrypted_volume*]
# Defaults to false
# Defaults to $facts['os_service_default']
# [*resize_available*]
# Defaults to $facts['os_service_default']
# [*vnc_console*]
@@ -440,7 +440,7 @@ class tempest(
$volume_build_timeout = $facts['os_service_default'],
$object_storage_build_timeout = $facts['os_service_default'],
# testing features that are supported
$attach_encrypted_volume = false,
$attach_encrypted_volume = $facts['os_service_default'],
$resize_available = $facts['os_service_default'],
$vnc_console = $facts['os_service_default'],
$use_dynamic_credentials = $facts['os_service_default'],

7
releasenotes/notes/attach_encrypted_volume-service-default-87351b835ea0f03d.yaml Normal file
View File

@@ -0,0 +1,7 @@
---
upgrade:
- |
The ``tempest::attach_encrypted_volume`` parameter now defaults to
the ``os_service_default`` fact, which means the corresponding option is
cleared by default. Set this parameter in case the previous default value
(`false`) is preferred.

2
spec/classes/tempest_init_spec.rb
View File

@@ -215,7 +215,7 @@ describe 'tempest' do
is_expected.to contain_tempest_config('volume/build_interval').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('volume/build_timeout').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('object-storage/build_timeout').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('compute-feature-enabled/attach_encrypted_volume').with(:value => false)
is_expected.to contain_tempest_config('compute-feature-enabled/attach_encrypted_volume').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('compute-feature-enabled/resize').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('compute-feature-enabled/vnc_console').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('validation/image_ssh_user').with(:value => nil)