openstack/puppet-tempest
Code Issues Proposed changes

deprecate verbose parameter

Browse Source 
verbose parameter is deprecated in Tempest and does nothing.
It will be removed in a future release.

Change-Id: I6233294adfea9dd03697cf4c6544d5bf01787d9f
This commit is contained in:
Emilien Macchi 2016-04-18 16:01:12 -04:00
parent e70aa88930
commit 7af94e013b
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
manifests/init.pp
View File

@ -41,8 +41,6 @@
# Defaults to '/var/lib/tempest' # Defaults to '/var/lib/tempest'
# [*debug*] # [*debug*]
# Defaults to false # Defaults to false
# [*verbose*]
# Defaults to false
# [*use_stderr*] # [*use_stderr*]
# Defaults to true # Defaults to true
# [*use_syslog*] # [*use_syslog*]
@ -155,6 +153,9 @@
# [*manage_tests_packages*] # [*manage_tests_packages*]
# Defaults to false # Defaults to false
# #
# DEPREACTED PARAMETERS
# [*verbose*]
# Defaults to false
class tempest( class tempest(
$install_from_source = true, $install_from_source = true,
$git_clone = true, $git_clone = true,
@ -191,7 +192,6 @@ class tempest(
$cli_dir = undef, $cli_dir = undef,
$lock_path = '/var/lib/tempest', $lock_path = '/var/lib/tempest',
$debug = false, $debug = false,
$verbose = false,
$use_stderr = true, $use_stderr = true,
$use_syslog = false, $use_syslog = false,
$log_file = undef, $log_file = undef,
@ -256,8 +256,14 @@ class tempest(
# scenario options # scenario options
$img_dir = '/var/lib/tempest', $img_dir = '/var/lib/tempest',
$img_file = 'cirros-0.3.4-x86_64-disk.img', $img_file = 'cirros-0.3.4-x86_64-disk.img',
# DEPRECATED PARAMETERS
$verbose = false,
) { ) {
if $verbose {
warning('verbose is deprecated and does nothing. Will be remove in a future release.')
}
include ::tempest::params include ::tempest::params
include ::openstacklib::openstackclient include ::openstacklib::openstackclient
@ -372,7 +378,6 @@ class tempest(
'cli/cli_dir': value => $cli_dir; 'cli/cli_dir': value => $cli_dir;
'oslo_concurrency/lock_path': value => $lock_path; 'oslo_concurrency/lock_path': value => $lock_path;
'DEFAULT/debug': value => $debug; 'DEFAULT/debug': value => $debug;
'DEFAULT/verbose': value => $verbose;
'DEFAULT/use_stderr': value => $use_stderr; 'DEFAULT/use_stderr': value => $use_stderr;
'DEFAULT/use_syslog': value => $use_syslog; 'DEFAULT/use_syslog': value => $use_syslog;
'DEFAULT/log_file': value => $log_file; 'DEFAULT/log_file': value => $log_file;

4
releasenotes/notes/verbose_deprecated-199b555f384fb0fc.yaml Normal file
View File

@ -0,0 +1,4 @@
---
deprecations:
- verbose parameter is deprecated and does nothing. It will be removed
in a future release.

1
spec/classes/tempest_spec.rb
View File

@ -220,7 +220,6 @@ describe 'tempest' do
is_expected.to contain_tempest_config('cli/cli_dir').with(:value => nil) is_expected.to contain_tempest_config('cli/cli_dir').with(:value => nil)
is_expected.to contain_tempest_config('oslo_concurrency/lock_path').with(:value => '/var/lib/tempest') is_expected.to contain_tempest_config('oslo_concurrency/lock_path').with(:value => '/var/lib/tempest')
is_expected.to contain_tempest_config('DEFAULT/debug').with(:value => false) is_expected.to contain_tempest_config('DEFAULT/debug').with(:value => false)
is_expected.to contain_tempest_config('DEFAULT/verbose').with(:value => false)
is_expected.to contain_tempest_config('DEFAULT/use_stderr').with(:value => true) is_expected.to contain_tempest_config('DEFAULT/use_stderr').with(:value => true)
is_expected.to contain_tempest_config('DEFAULT/use_syslog').with(:value => false) is_expected.to contain_tempest_config('DEFAULT/use_syslog').with(:value => false)
is_expected.to contain_tempest_config('DEFAULT/log_file').with(:value => nil) is_expected.to contain_tempest_config('DEFAULT/log_file').with(:value => nil)