openstack/puppet-tempest
Code Issues Proposed changes

Deprecate a parameter for whitebox-tempest-plugin

Browse Source 
The plugin has never been supported by puppet-tempest. Also, currently
no distribution provides the package.

Change-Id: Ib87b5f44134adefea92d73dd91276de6773e9bab
This commit is contained in:
Takashi Kajinami 2022-06-16 22:37:02 +09:00
parent 7b20e48cec
commit 9f2d6ea650
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
manifests/init.pp
View File

@ -108,8 +108,6 @@
# Defaults to undef
# [*flavor_ref_alt*]
# Defaults to undef
# [*whitebox_db_uri*]
# Defaults to undef
# [*resize_available*]
# Defaults to false
# [*use_dynamic_credentials*]
@ -243,6 +241,8 @@
# Defaults to false
# [*glance_v2*]
# Defaults to true
# [*whitebox_db_uri*]
# Defaults to undef
#
class tempest(
$package_ensure = 'present',
@ -321,8 +321,6 @@ class tempest(
$compute_build_interval = undef,
$run_ssh = false,
$ssh_key_type = $::os_service_default,
# whitebox
$whitebox_db_uri = undef,
# testing features that are supported
$resize_available = false,
$use_dynamic_credentials = undef,
@ -394,6 +392,7 @@ class tempest(
# DEPRECATED PARAMETERS
$glance_v1 = undef,
$glance_v2 = undef,
$whitebox_db_uri = undef,
) {
if $glance_v1 != undef {
@ -404,6 +403,10 @@ class tempest(
warning('The glance_v2 parameter has been deprecated and will be removed in a future release.')
}
if $whitebox_db_uri != undef {
warning('The whitebox_db_uri parameter has been deprecated and has no effect.')
}
include tempest::params
include openstacklib::openstackclient
@ -577,7 +580,6 @@ class tempest(
'identity-feature-enabled/enforce_scope': value => $keystone_enforce_scope;
'enforce_scope/neutron': value => $neutron_enforce_scope;
'enforce_scope/nova': value => $nova_enforce_scope;
'whitebox/db_uri': value => $whitebox_db_uri;
'cli/cli_dir': value => $cli_dir;
'scenario/img_file': value => $img_file;
'scenario/img_disk_format': value => $img_disk_format;

5
releasenotes/notes/deprecate-whitebox-380760e888224807.yaml Normal file
View File

@ -0,0 +1,5 @@
---
deprecations:
- |
The ``tempest::whitebox_db_uri`` parameter has been deprecated and now has
no effect.

1
spec/classes/tempest_init_spec.rb
View File

@ -279,7 +279,6 @@ describe 'tempest' do
is_expected.to contain_tempest_config('load_balancer/observer_role').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('load_balancer/global_observer_role').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('load_balancer/test_with_noop').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('whitebox/db_uri').with(:value => nil)
is_expected.to contain_tempest_config('cli/cli_dir').with(:value => nil)
is_expected.to contain_oslo__concurrency('tempest_config').with(
:lock_path => '/var/lib/tempest'