openstack/puppet-tempest
Code Issues Proposed changes

Support [compute-feature-enabled] vnc_console

Browse Source 
... so that we can run some tests to validate functionality of vnc
console access.

Change-Id: I62f9c98ec08c53c4765446a9f714f1f07f4e05ca
This commit is contained in:
Takashi Kajinami 2024-11-09 16:34:17 +09:00
parent f41a63ebce
commit ab921761f3
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/init.pp
View File

@ -112,8 +112,12 @@
# Defaults to undef # Defaults to undef
# [*flavor_name_alt*] # [*flavor_name_alt*]
# Defaults to undef # Defaults to undef
# [*attach_encrypted_volume*]
# Defaults to false
# [*resize_available*] # [*resize_available*]
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# [*vnc_console*]
# Defaults to $facts['os_service_default']
# [*use_dynamic_credentials*] # [*use_dynamic_credentials*]
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# [*l2gw_switch*] # [*l2gw_switch*]
@ -288,8 +292,6 @@
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# [*manage_tests_packages*] # [*manage_tests_packages*]
# Defaults to false # Defaults to false
# [*attach_encrypted_volume*]
# Defaults to false
# [*tempest_roles*] # [*tempest_roles*]
# Defaults to $facts['os_service_default'] # Defaults to $facts['os_service_default']
# [*reseller_admin_role*] # [*reseller_admin_role*]
@ -389,7 +391,6 @@ class tempest(
$use_syslog = $facts['os_service_default'], $use_syslog = $facts['os_service_default'],
$logging_context_format_string = $facts['os_service_default'], $logging_context_format_string = $facts['os_service_default'],
$http_timeout = $facts['os_service_default'], $http_timeout = $facts['os_service_default'],
$attach_encrypted_volume = false,
# non admin user # non admin user
$username = undef, $username = undef,
$password = undef, $password = undef,
@ -437,7 +438,9 @@ class tempest(
$volume_build_timeout = $facts['os_service_default'], $volume_build_timeout = $facts['os_service_default'],
$object_storage_build_timeout = $facts['os_service_default'], $object_storage_build_timeout = $facts['os_service_default'],
# testing features that are supported # testing features that are supported
$attach_encrypted_volume = false,
$resize_available = $facts['os_service_default'], $resize_available = $facts['os_service_default'],
$vnc_console = $facts['os_service_default'],
$use_dynamic_credentials = $facts['os_service_default'], $use_dynamic_credentials = $facts['os_service_default'],
$l2gw_switch = $facts['os_service_default'], $l2gw_switch = $facts['os_service_default'],
# neutron config # neutron config
@ -765,6 +768,7 @@ class tempest(
'service_broker/run_service_broker_tests': value => $run_service_broker_tests; 'service_broker/run_service_broker_tests': value => $run_service_broker_tests;
'compute-feature-enabled/attach_encrypted_volume': value => $attach_encrypted_volume; 'compute-feature-enabled/attach_encrypted_volume': value => $attach_encrypted_volume;
'compute-feature-enabled/resize': value => $resize_available; 'compute-feature-enabled/resize': value => $resize_available;
'compute-feature-enabled/vnc_console': value => $vnc_console;
# designate-tempest-plugin # designate-tempest-plugin
'dns/nameservers': value => join(any2array($designate_nameservers), ','); 'dns/nameservers': value => join(any2array($designate_nameservers), ',');
# heat-tempest-plugin # heat-tempest-plugin

4
releasenotes/notes/vnc_console-b2023cc4002b276a.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The new ``tempest::vnc_console`` parameter has been added.

1
spec/classes/tempest_init_spec.rb
View File

@ -216,6 +216,7 @@ describe 'tempest' do
is_expected.to contain_tempest_config('object-storage/build_timeout').with(:value => '<SERVICE DEFAULT>') is_expected.to contain_tempest_config('object-storage/build_timeout').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('compute-feature-enabled/attach_encrypted_volume').with(:value => false) is_expected.to contain_tempest_config('compute-feature-enabled/attach_encrypted_volume').with(:value => false)
is_expected.to contain_tempest_config('compute-feature-enabled/resize').with(:value => '<SERVICE DEFAULT>') is_expected.to contain_tempest_config('compute-feature-enabled/resize').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('compute-feature-enabled/vnc_console').with(:value => '<SERVICE DEFAULT>')
is_expected.to contain_tempest_config('validation/image_ssh_user').with(:value => nil) is_expected.to contain_tempest_config('validation/image_ssh_user').with(:value => nil)
is_expected.to contain_tempest_config('validation/image_alt_ssh_user').with(:value => nil) is_expected.to contain_tempest_config('validation/image_alt_ssh_user').with(:value => nil)
is_expected.to contain_tempest_config('validation/run_validation').with(:value => false) is_expected.to contain_tempest_config('validation/run_validation').with(:value => false)