openstack/puppet-tempest
Code Issues Proposed changes

Use validate_legacy

Browse Source 
This changes all the puppet 3 validate_* functions
to use the validate_legacy function.

The validate_legacy function has been available since
about three years but require Puppet >= 4.4.0 and since
there is Puppet 4.10.12 as latest we should assume people
are running a fairly new Puppet 4 version.

This is the first step to then remove all validate function
calls and use proper types for parameter as described in spec [1].

[1] https://review.openstack.org/#/c/568929/

Change-Id: Ic78b27163bfada850e246de4765fcc130db2b49b
This commit is contained in:
Tobias Urdin 2019-02-23 23:00:40 +01:00
parent 172955d2dc
commit b15d4005cd
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/config.pp
View File

@ -31,7 +31,7 @@ class tempest::config (
$tempest_config = {},
) {
validate_hash($tempest_config)
validate_legacy(Hash, 'validate_hash', $tempest_config)
create_resources('tempest_config', $tempest_config)
}

2
manifests/init.pp
View File

@ -372,7 +372,7 @@ class tempest(
) {
if !is_service_default($tempest_roles) and !empty($tempest_roles){
validate_array($tempest_roles)
validate_legacy(Array, 'validate_array', $tempest_roles)
$tempest_roles_real = join($tempest_roles, ',')
} else {
$tempest_roles_real = $::os_service_default