deploy openstackclient and make our providers requiring it

* Deploy python-openstackclient, required by our providers to execute
  CLI against Glance & Neutron APIs.
* Require the package before trying to execute the providers.

Change-Id: I3b3523d947421583a8e926a2419055a5869291d4

lib/puppet/type/tempest_glance_id_setter.rb

@@ -20,4 +20,7 @@ Puppet::Type.newtype(:tempest_glance_id_setter) do
     desc 'name of glance image'
   end
 
+  autorequire(:package) do
+    ['python-openstackclient']
+  end
 end

lib/puppet/type/tempest_neutron_net_id_setter.rb

@@ -14,4 +14,7 @@ Puppet::Type.newtype(:tempest_neutron_net_id_setter) do
     desc 'The name of the neutron network.'
   end
 
+  autorequire(:package) do
+    ['python-openstackclient']
+  end
 end

manifests/init.pp

@@ -257,6 +257,8 @@ class tempest(
 
   include ::tempest::params
 
+  include ::openstacklib::openstackclient
+
   if $install_from_source {
     ensure_packages([
       'git',

releasenotes/notes/osclient-fccb30722f2d46a0.yaml

@@ -0,0 +1,5 @@
+---
+features:
+  - Installation of python-openstackclient by default and make sure the
+    package is installed before executing our providers that use OpenStack
+    APIs.

spec/classes/tempest_spec.rb

@@ -160,6 +160,12 @@ describe 'tempest' do
           )
         end
 
+        it 'installs python-openstackclient package' do
+          is_expected.to contain_package('python-openstackclient').with(
+            :tag => 'openstack'
+          )
+        end
+
         it 'configure tempest config' do
           is_expected.to contain_tempest_config('compute/change_password_available').with(:value => nil)
           is_expected.to contain_tempest_config('compute/flavor_ref').with(:value => nil)