With the creation of the new openstack_config provider, some processing
that was done in tempest_config has been centralized in
openstack_config.
Impacted methods are :
* section
* setting
* separator
Also, this commit adds the fact that, when passing a specific string
(ensure_absent_val) the provider will behave as if ensure => absent was
specified. '<SERVICE DEFAULT>' is the default value for
ensure_absent_val.
The use case is the following :
tempest_config { 'DEFAULT/foo' : value => 'bar' } # will work as usual
tempest_config { 'DEFAULT/foo' : value => '<SERVICE DEFAULT>' } # will mean absent
That means that all the current :
if $myvar {
tempest_config { 'DEFAULT/foo' : value => $myvar }
} else {
tempest_config { 'DEFAULT/foo' : ensure => absent }
}
can be removed in favor of :
tempest_config { 'DEFAULT/foo' : value => $myvar }
If for any reason '<SERVICE DEFAULT>' turns out to be a valid value for
a specific parameter. One could by pass that doing the following :
tempest_config { 'DEFAULT/foo' : value => '<SERVICE DEFAULT>',
ensure_absent_val => 'foo' }
Change-Id: Idb64253273ef5a1e4bc0311e1d5bb265a820b9b7
Depends-On: I0eeebde3aac2662cc7e69bfad7f8d2481463a218
* The previous way of customizing tempest.conf was problematic
for a number of reasons:
- default values were being defined in the manifest and those
values differed from the defaults in tempest.conf.sample.
Defaults should be the province of the tempest maintainers,
not the puppet module.
- the use of templating meant that extra work would have to be
expended maintaining the templates, not only for releases
but also for the upstream master.
* This changeset switches to using ini_setting to ensure that:
- individual configuration settings can be set ad hoc, and
the upstream defaults will be left alone if no value is provided.
- tempest.conf can be sourced from the tempest repo sample rather
than having to be maintained in the module.
* Other included fixes:
- removing unused glance uri configuration
- consolidating the identity uri parameters into a single parameter,
since that is how it is represented in tempest.conf
Change-Id: Idcdf7a1002a447b7d3ae909ca9043b8d7143c313