openstack/puppet-tripleo
Code Issues Proposed changes

Remove tuned puppet manifest

Browse Source 
The tuned puppet manifest is being removed because the heat template
which invoked it has been converted to ansible. This change removes
the tuned manifest and spec files accordingly.

Depends-On: I06d07f6f0949095cb716dd706e05f2e567c0d3d8

Change-Id: I1c76efb07474f8b0f5e226712aad30a75f6843af
Signed-off-by: Kevin Carter <kecarter@redhat.com>
This commit is contained in:
Kevin Carter 2019-05-28 10:34:58 -05:00 committed by Alex Schultz
parent 392eacb092
commit 04c6f343e2
3 changed files with 4 additions and 106 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
manifests/profile/base/tuned.pp
View File

@ -1,41 +0,0 @@
# == Class: tripleo::profile::base::tuned
#
# Configures tuned service.
#
# === Parameters:
#
# [*profile*]
# (optional) tuned active profile.
# Defaults to 'throughput-performance'
#
# [*custom_profile*]
# (optional) string in INI format defining a custom profile
# Defaults to undef
#
class tripleo::profile::base::tuned (
$profile = 'throughput-performance',
$custom_profile = undef
) {
ensure_resource('package', 'tuned', { ensure => 'present' })
if !empty($custom_profile) {
file { "/etc/tuned/${profile}":
ensure => 'directory',
owner => 'root',
group => 'root',
mode => '0755',
} -> file { "/etc/tuned/${profile}/tuned.conf":
ensure => present,
before => Exec['tuned-adm'],
owner => 'root',
group => 'root',
mode => '0644',
content => $custom_profile,
}
}
exec { 'tuned-adm':
path => ['/bin', '/usr/bin', '/sbin', '/usr/sbin'],
command => "tuned-adm profile ${profile}",
unless => "tuned-adm active | grep -q '${profile}'",
require => Package['tuned'],
}
}

4
releasenotes/notes/tuned-removed-ab68a7109a1e7403.yaml Normal file
View File

@ -0,0 +1,4 @@
---
deprecations:
- The tuned puppet manifest for `tuned` was removed. The heat template
invoking this manifest has been converted to Ansible.

65
spec/classes/tripleo_profile_base_tuned_spec.rb
View File

@ -1,65 +0,0 @@
#
# Copyright (C) 2017 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
require 'spec_helper'
describe 'tripleo::profile::base::tuned' do
shared_examples_for 'tripleo::profile::base::tuned' do
context 'with profile' do
let :params do
{
:profile => 'virtual-compute'
}
end
it 'should run tuned-adm exec' do
is_expected.to contain_exec('tuned-adm')
end
end
context 'with custom profile' do
let :params do
{
:profile => 'custom',
:custom_profile => 'foo'
}
end
it 'should create a custom tuned profile' do
is_expected.to contain_file('/etc/tuned/custom/tuned.conf').with({
'content' => 'foo',
'owner' => 'root',
'group' => 'root',
'mode' => '0644',
})
end
it 'should run a tuned-adm exec to set the custom profile' do
is_expected.to contain_exec('tuned-adm').with_command(
'tuned-adm profile custom'
)
end
end
end
on_supported_os.each do |os, facts|
context "on #{os}" do
let(:facts) {
facts
}
it_behaves_like 'tripleo::profile::base::tuned'
end
end
end