openstack
/
puppet-tripleo
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(1 comment)

Patch-set: 6
Reviewer: Gerrit User 9816 <9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 9816 2022-03-04 12:05:06 +00:00 committed by Gerrit Code Review
parent 1a1a4cf824
commit 15fc7af8e8
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
5ef8c197d3344248c84f0f478f64a5d2cd035bbc
View File

@ -33,6 +33,23 @@
"message": "check-rdo\nfailure during node provisioning",
"revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ef603aae_657338c3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 9816
},
"writtenOn": "2022-03-04T12:05:06Z",
"side": 1,
"message": "I\u0027m still trying to understand the exact requirement, but my first impression of this patch is that altering part of url in puppet is too tricky and is hard to maintain.\n\nIMO we should generate a properly encoded password string in tripleo-common as new *Password parameters and use these passwords in t-h-t to compose database url.",
"revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}