openstack
/
puppet-tripleo
Code Issues Proposed changes

Add missing unit tests for heat manifests 

Change-Id: Idc463119cbd183f34ae206be55c695818ee9c9b5
This commit is contained in:
Takashi Kajinami 2020-03-28 11:39:18 +09:00
parent 991d52605c
commit 1b54512b2f
5 changed files with 468 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

105
spec/classes/tripleo_profile_base_heat_api_cfn_spec.rb Normal file
View File

@ -0,0 +1,105 @@
#
# Copyright (C) 2020 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
require 'spec_helper'
describe 'tripleo::profile::base::heat::api_cfn' do
shared_examples_for 'tripleo::profile::base::heat::api_cfn' do
let(:pre_condition) do
<<-eos
class { 'tripleo::profile::base::heat::authtoken':
step => #{params[:step]},
}
class { 'tripleo::profile::base::heat':
step => #{params[:step]},
oslomsg_rpc_hosts => [ 'localhost' ],
oslomsg_rpc_username => 'heat',
oslomsg_rpc_password => 'foo'
}
eos
end
context 'with step less than 3' do
let(:params) { {
:step => 1,
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api_cfn')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to_not contain_class('heat::api_cfn')
is_expected.to_not contain_class('tripleo::profile::base::apache')
is_expected.to_not contain_class('heat::wsgi::apache_api_cfn')
}
end
context 'with step 3 on bootstrap node' do
let(:params) { {
:step => 3,
:bootstrap_node => 'node.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api_cfn')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('heat::api_cfn')
is_expected.to contain_class('tripleo::profile::base::apache')
is_expected.to contain_class('heat::wsgi::apache_api_cfn')
}
end
context 'with step 3 not on bootstrap node' do
let(:params) { {
:step => 3,
:bootstrap_node => 'other.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api_cfn')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to_not contain_class('heat::api_cfn')
is_expected.to_not contain_class('tripleo::profile::base::apache')
is_expected.to_not contain_class('heat::wsgi::apache_api_cfn')
}
end
context 'with step 4 not on bootstrap node' do
let(:params) { {
:step => 4,
:bootstrap_node => 'other.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api_cfn')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('heat::api_cfn')
is_expected.to contain_class('tripleo::profile::base::apache')
is_expected.to contain_class('heat::wsgi::apache_api_cfn')
}
end
end
on_supported_os.each do |os, facts|
context "on #{os}" do
let(:facts) do
facts.merge({ :hostname => 'node.example.com' })
end
it_behaves_like 'tripleo::profile::base::heat::api_cfn'
end
end
end

105
spec/classes/tripleo_profile_base_heat_api_spec.rb Normal file
View File

@ -0,0 +1,105 @@
#
# Copyright (C) 2020 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
require 'spec_helper'
describe 'tripleo::profile::base::heat::api' do
shared_examples_for 'tripleo::profile::base::heat::api' do
let(:pre_condition) do
<<-eos
class { 'tripleo::profile::base::heat::authtoken':
step => #{params[:step]},
}
class { 'tripleo::profile::base::heat':
step => #{params[:step]},
oslomsg_rpc_hosts => [ 'localhost' ],
oslomsg_rpc_username => 'heat',
oslomsg_rpc_password => 'foo'
}
eos
end
context 'with step less than 3' do
let(:params) { {
:step => 1,
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to_not contain_class('heat::api')
is_expected.to_not contain_class('tripleo::profile::base::apache')
is_expected.to_not contain_class('heat::wsgi::apache_api')
}
end
context 'with step 3 on bootstrap node' do
let(:params) { {
:step => 3,
:bootstrap_node => 'node.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('heat::api')
is_expected.to contain_class('tripleo::profile::base::apache')
is_expected.to contain_class('heat::wsgi::apache_api')
}
end
context 'with step 3 not on bootstrap node' do
let(:params) { {
:step => 3,
:bootstrap_node => 'other.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to_not contain_class('heat::api')
is_expected.to_not contain_class('tripleo::profile::base::apache')
is_expected.to_not contain_class('heat::wsgi::apache_api')
}
end
context 'with step 4 not on bootstrap node' do
let(:params) { {
:step => 4,
:bootstrap_node => 'other.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::api')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('heat::api')
is_expected.to contain_class('tripleo::profile::base::apache')
is_expected.to contain_class('heat::wsgi::apache_api')
}
end
end
on_supported_os.each do |os, facts|
context "on #{os}" do
let(:facts) do
facts.merge({ :hostname => 'node.example.com' })
end
it_behaves_like 'tripleo::profile::base::heat::api'
end
end
end

97
spec/classes/tripleo_profile_base_heat_engine_spec.rb Normal file
View File

@ -0,0 +1,97 @@
#
# Copyright (C) 2020 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
require 'spec_helper'
describe 'tripleo::profile::base::heat::engine' do
shared_examples_for 'tripleo::profile::base::heat::engine' do
let(:pre_condition) do
<<-eos
class { 'tripleo::profile::base::heat::authtoken':
step => #{params[:step]},
}
class { 'tripleo::profile::base::heat':
step => #{params[:step]},
oslomsg_rpc_hosts => [ 'localhost' ],
oslomsg_rpc_username => 'heat',
oslomsg_rpc_password => 'foo'
}
eos
end
context 'with step less than 3' do
let(:params) { {
:step => 1,
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::engine')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to_not contain_class('heat::engine')
}
end
context 'with step 3 on bootstrap node' do
let(:params) { {
:step => 3,
:bootstrap_node => 'node.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::engine')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('heat::engine')
}
end
context 'with step 3 not on bootstrap node' do
let(:params) { {
:step => 3,
:bootstrap_node => 'other.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::engine')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to_not contain_class('heat::engine')
}
end
context 'with step 4 not on bootstrap node' do
let(:params) { {
:step => 4,
:bootstrap_node => 'other.example.com',
} }
it {
is_expected.to contain_class('tripleo::profile::base::heat::engine')
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('heat::engine')
}
end
end
on_supported_os.each do |os, facts|
context "on #{os}" do
let(:facts) do
facts.merge({ :hostname => 'node.example.com' })
end
it_behaves_like 'tripleo::profile::base::heat::engine'
end
end
end

156
spec/classes/tripleo_profile_base_heat_spec.rb Normal file
View File

@ -0,0 +1,156 @@
#
# Copyright (C) 2020 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
require 'spec_helper'
describe 'tripleo::profile::base::heat' do
shared_examples_for 'tripleo::profile::base::heat' do
let(:pre_condition) do
<<-eos
class { 'tripleo::profile::base::heat::authtoken':
step => #{params[:step]},
}
eos
end
context 'with step less than 3' do
let(:params) { { :step => 1 } }
it 'should do nothing' do
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('tripleo::profile::base::heat::authtoken')
is_expected.to_not contain_class('heat::keystone::domain')
is_expected.to_not contain_class('heat')
is_expected.to_not contain_class('heat::config')
is_expected.to_not contain_class('heat::cors')
is_expected.to_not contain_class('heat::logging')
is_expected.to_not contain_class('heat::cache')
is_expected.to_not contain_class('heat::cron::purge_deleted')
end
end
context 'with step 3' do
let(:params) { {
:step => 3,
:oslomsg_rpc_hosts => [ '192.168.0.1' ],
:oslomsg_rpc_username => 'heat1',
:oslomsg_rpc_password => 'foo',
:oslomsg_rpc_port => '1234',
:oslomsg_notify_hosts => [ '192.168.0.2' ],
:oslomsg_notify_username => 'heat2',
:oslomsg_notify_password => 'baa',
:oslomsg_notify_port => '5678'
} }
it 'should trigger complete configuration without db_purge' do
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('tripleo::profile::base::heat::authtoken')
is_expected.to contain_class('heat::keystone::domain').with(
:manage_domain => false,
:manage_user => false,
:manage_role => false
)
is_expected.to contain_class('heat').with(
:default_transport_url => 'rabbit://heat1:foo@192.168.0.1:1234/?ssl=0',
:notification_transport_url => 'rabbit://heat2:baa@192.168.0.2:5678/?ssl=0'
)
is_expected.to contain_class('heat::config')
is_expected.to contain_class('heat::cors')
is_expected.to contain_class('heat::logging')
is_expected.to contain_class('heat::cache')
is_expected.to_not contain_class('heat::cron::purge_deleted')
end
end
context 'with step 5' do
let(:params) { {
:step => 5,
:oslomsg_rpc_hosts => [ '192.168.0.1' ],
:oslomsg_rpc_username => 'heat1',
:oslomsg_rpc_password => 'foo',
:oslomsg_rpc_port => '1234',
:oslomsg_notify_hosts => [ '192.168.0.2' ],
:oslomsg_notify_username => 'heat2',
:oslomsg_notify_password => 'baa',
:oslomsg_notify_port => '5678'
} }
it 'should trigger complete configuration' do
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('tripleo::profile::base::heat::authtoken')
is_expected.to contain_class('heat::keystone::domain').with(
:manage_domain => false,
:manage_user => false,
:manage_role => false
)
is_expected.to contain_class('heat').with(
:default_transport_url => 'rabbit://heat1:foo@192.168.0.1:1234/?ssl=0',
:notification_transport_url => 'rabbit://heat2:baa@192.168.0.2:5678/?ssl=0'
)
is_expected.to contain_class('heat::config')
is_expected.to contain_class('heat::cors')
is_expected.to contain_class('heat::logging')
is_expected.to contain_class('heat::cache')
is_expected.to contain_class('heat::cron::purge_deleted')
end
end
context 'with step 5 without db_purge' do
let(:params) { {
:step => 3,
:bootstrap_node => 'node.example.com',
:oslomsg_rpc_hosts => [ '192.168.0.1' ],
:oslomsg_rpc_username => 'heat1',
:oslomsg_rpc_password => 'foo',
:oslomsg_rpc_port => '1234',
:oslomsg_notify_hosts => [ '192.168.0.2' ],
:oslomsg_notify_username => 'heat2',
:oslomsg_notify_password => 'baa',
:oslomsg_notify_port => '5678',
:manage_db_purge => false
} }
it 'should trigger complete configuration without db_purge' do
is_expected.to contain_class('tripleo::profile::base::heat')
is_expected.to contain_class('tripleo::profile::base::heat::authtoken')
is_expected.to contain_class('heat::keystone::domain').with(
:manage_domain => false,
:manage_user => false,
:manage_role => false
)
is_expected.to contain_class('heat').with(
:default_transport_url => 'rabbit://heat1:foo@192.168.0.1:1234/?ssl=0',
:notification_transport_url => 'rabbit://heat2:baa@192.168.0.2:5678/?ssl=0'
)
is_expected.to contain_class('heat::config')
is_expected.to contain_class('heat::cors')
is_expected.to contain_class('heat::logging')
is_expected.to contain_class('heat::cache')
is_expected.to_not contain_class('heat::cron::purge_deleted')
end
end
end
on_supported_os.each do |os, facts|
context "on #{os}" do
let(:facts) do
facts.merge({ :hostname => 'node.example.com' })
end
it_behaves_like 'tripleo::profile::base::heat'
end
end
end

5
spec/fixtures/hieradata/default.yaml vendored
View File

@ -61,7 +61,12 @@ ironic_inspector_short_bootstrap_node_name: node
mysql_enabled: true
controller_node_ips: '10.1.0.1,10.1.0.2'
# heat related items
heat_api_short_bootstrap_node_name: node
heat_api_cfn_short_bootstrap_node_name: node
heat_engine_short_bootstrap_node_name: node
heat::keystone::authtoken::password: 'password'
heat::keystone::domain::domain_password: 'password'
heat::engine::auth_encryption_key: 'heat_auth_encrpytion_key'
# mysql related items
mysql_short_bootstrap_node_name: node
# manila related items