openstack
/
puppet-tripleo
Code Issues Proposed changes

collectd: Allow duplicate plugins 

Sometimes different services require the same collectd plugin. For
example, ceph-osd and ceph-mon require the common ceph.

This change makes sure that such duplicate requirements do not cause
resource declaration error.

This change is wallaby-backport-potential.

Change-Id: I5592967b3a7bb928265e2ca909cf88a1f92964be
This commit is contained in:
Takashi Kajinami 2022-12-07 11:10:51 +09:00 committed by Yadnesh Kulkarni
parent d79306a290
commit 220da27ac8
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
manifests/profile/base/metrics/collectd/collectd_service.pp
View File

@ -4,8 +4,11 @@ define tripleo::profile::base::metrics::collectd::collectd_service (
) {
$plugins = lookup("'tripleo.collectd.plugins.${title}'", undef, undef, [])
if $plugins {
::tripleo::profile::base::metrics::collectd::collectd_plugin {
$plugins: }
$plugins.each |$plugin| {
ensure_resource(
'tripleo::profile::base::metrics::collectd::collectd_plugin',
$plugin,
{}
)
}
}