openstack
/
puppet-tripleo
Code Issues Proposed changes

Make sure there is a space after debug in virtlogd_wrapper 

Otherwise when we set debug on we get the following start of
file:
  #!/bin/bash
  set -xARGS="$@"

This will then lead to the error:
2021-08-27T18:22:40.444492949+00:00 stderr F + exec /usr/local/bin/virtlogd_wrapper
2021-08-27T18:22:40.444492949+00:00 stderr F /usr/local/bin/virtlogd_wrapper: line 2: set: -A: invalid option
2021-08-27T18:22:40.444492949+00:00 stderr F set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
2021-08-27T18:22:40.763849194+00:00 stdout F Starting a new child container nova_virtlogd
2021-08-27T18:22:41.016340084+00:00 stdout F c46e5d5a121e11aec40264f3473b37e7edeabf6f9404d49666645252a8db63a3

After this change, with debug always on, we correctly get:
  #!/bin/bash
  set -x
  ARGS="$@"
  NAME=nova_virtlogd

Change-Id: Ic2f376e7bfca1ed3d53994994746995fa8fb2366
This commit is contained in:
Michele Baldessari 2021-08-27 21:10:33 +02:00
parent 4931d2cce8
commit 2384b77a5b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
templates/nova/virtlogd.epp
View File

@ -2,7 +2,7 @@
Boolean $debug
| -%>
#!/bin/bash
<%- if $debug { -%>set -x<%- } -%>
<%- if $debug { -%>set -x<%- } %>
ARGS="$@"
NAME=nova_virtlogd
CMD='/usr/sbin/virtlogd --config /etc/libvirt/virtlogd.conf'