correct unit tests

Moved to on_supported_os instead of hard-coded list

Change-Id: Id501931b7cb32463680cc861ab4e70230e2d98d1

spec/defines/tripleo_firewall_service_rules_spec.rb

@@ -25,21 +25,13 @@ describe 'tripleo::firewall::service_rules' do
     end
   end
 
-  context 'on Debian platforms' do
+  on_supported_os.each do |os, facts|
-    let :facts do
+    context "on #{os}" do
-      { :osfamily => 'Debian',
+      let(:facts) do
-        :hostname => 'myhost' }
+        facts.merge({})
       end
 
-    it_configures 'tripleo firewall service rules'
+      it_behaves_like 'tripleo firewall service rules'
     end
-
-  context 'on RedHat platforms' do
-    let :facts do
-      { :osfamily => 'RedHat',
-        :hostname => 'myhost' }
-    end
-
-    it_configures 'tripleo firewall service rules'
   end
 end

spec/defines/tripleo_haproxy_endpoint_spec.rb

@@ -52,21 +52,13 @@ describe 'tripleo::haproxy::endpoint' do
    end
   end
 
-  context 'on Debian platforms' do
+  on_supported_os.each do |os, facts|
-    let :facts do
+    context "on #{os}" do
-      { :osfamily => 'Debian',
+      let(:facts) do
-        :hostname => 'myhost' }
+        facts.merge({})
       end
 
-    it_configures 'tripleo haproxy endpoint'
+      it_behaves_like 'tripleo haproxy endpoint'
     end
-
-  context 'on RedHat platforms' do
-    let :facts do
-      { :osfamily => 'RedHat',
-        :hostname => 'myhost' }
-    end
-
-    it_configures 'tripleo haproxy endpoint'
   end
 end

spec/defines/tripleo_haproxy_service_endpoints_spec.rb

@@ -25,21 +25,13 @@ describe 'tripleo::haproxy::service_endpoints' do
     end
   end
 
-  context 'on Debian platforms' do
+  on_supported_os.each do |os, facts|
-    let :facts do
+    context "on #{os}" do
-      { :osfamily => 'Debian',
+      let(:facts) do
-        :hostname => 'myhost' }
+        facts.merge({})
       end
 
-    it_configures 'tripleo haproxy service_endpoints'
+      it_behaves_like 'tripleo haproxy service_endpoints'
     end
-
-  context 'on RedHat platforms' do
-    let :facts do
-      { :osfamily => 'RedHat',
-        :hostname => 'myhost' }
-    end
-
-    it_configures 'tripleo haproxy service_endpoints'
   end
 end