openstack/puppet-tripleo
Code Issues Proposed changes

Cleanup the firewall logic.

Browse Source 
We added code in t-h-t to strip empty services from the service_names
list. (These are often the result of a service set to OS::Heat::None).

As such we can now drop this puppet reject statement.

Change-Id: Ie66f14f183de7e44a1f69af862f7d4be9a14c904
This commit is contained in:
Dan Prince 2016-10-04 10:11:55 -04:00
parent 264d49a255
commit 39c9c6508a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/firewall.pp
View File

@ -102,7 +102,7 @@ class tripleo::firewall(
# dport: 999
# proto: udp
# action: accept
$service_names = reject(hiera('service_names', []), '^$')
$service_names = hiera('service_names', [])
tripleo::firewall::service_rules { $service_names: }
}