openstack
/
puppet-tripleo
Code Issues Proposed changes

Ensure package updates don't happen unexpectedly 

I'm seeing this run yum update on deploy, even though hiera
tripleo::packages::enable_upgrade says false.

I assume these are needed because we're getting "false", but I'm
unclear if this is a recently introduced problem (I only noticed it
today as my image has outdated centos packages and it thus hung on
step2 of the deploy.

Change-Id: If09cdde9883f2674dbbc40944be5fe4445caa08e
Closes-Bug: #1652107
This commit is contained in:
Steven Hardy 2016-12-22 16:42:12 +00:00
parent 918bed5db0
commit 3d8dfa1714
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/packages.pp
View File

@ -35,7 +35,7 @@ class tripleo::packages (
# required for stages
include ::stdlib
if !$enable_install and !$enable_upgrade {
if !str2bool($enable_install) and !str2bool($enable_upgrade) {
case $::osfamily {
'RedHat': {
Package <| |> { provider => 'norpm' }
@ -46,7 +46,7 @@ class tripleo::packages (
}
}
if $enable_upgrade {
if str2bool($enable_upgrade) {
Package <| |> { ensure => 'latest' }
# Running the package upgrade before managing Services in the main stage.
# So we're sure that services will be able to restart with the new version