From 596b4393acb938352cafcdfd5c17e4716a6adf12 Mon Sep 17 00:00:00 2001 From: Gerrit User 20778 <20778@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 18 Mar 2022 08:45:37 +0000 Subject: [PATCH] Update patch set 6 Patch Set 6: (1 comment) Patch-set: 6 Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Damien Ciabrini replied on the change"} Attention: {"person_ident":"Gerrit User 20778 \u003c20778@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Damien Ciabrini replied on the change"} --- 5ef8c197d3344248c84f0f478f64a5d2cd035bbc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/5ef8c197d3344248c84f0f478f64a5d2cd035bbc b/5ef8c197d3344248c84f0f478f64a5d2cd035bbc index dfd47e1a1..d09a9006a 100644 --- a/5ef8c197d3344248c84f0f478f64a5d2cd035bbc +++ b/5ef8c197d3344248c84f0f478f64a5d2cd035bbc @@ -50,6 +50,24 @@ "message": "I\u0027m still trying to understand the exact requirement, but my first impression of this patch is that altering part of url in puppet is too tricky and is hard to maintain.\n\nIMO we should generate a properly encoded password string in tripleo-common as new *Password parameters and use these passwords in t-h-t to compose database url.", "revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "bd9dabbb_dd5233b3", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 6 + }, + "lineNbr": 0, + "author": { + "id": 20778 + }, + "writtenOn": "2022-03-18T08:45:37Z", + "side": 1, + "message": "Fair enough, thanks for the feedback.\nI reworked the approach as you proposed in \nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/833616\nHopefully the commit message in this review and its two dependencies (tripleo-common and puppet-tripleo) explains what I need to achieve.\nEither way, the new review doesn\u0027t bend the content of the hiera keys anymore.", + "parentUuid": "ef603aae_657338c3", + "revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file