openstack/puppet-tripleo
Code Issues Proposed changes

nova/libvirt: switch vnc server binding

Browse Source 
On compute nodes, instead of binding vnc server on 0.0.0.0, use the IP
address provided by libvirt's t-h-t profile (hiera).

Co-Authored-By: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Depends-On: Ie377c09734e9f6170daa519aed69c53fc67c366b
Change-Id: If6b116b238a52144aad5e76c9edc7df6aa15313c
Closes-Bug: #1660099
This commit is contained in:
Emilien Macchi 2017-01-31 13:20:51 -05:00 committed by Juan Antonio Osorio Robles
parent 2b11f29824
commit 6556123395
2 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
manifests/profile/base/nova/compute/libvirt.pp
View File

@ -40,24 +40,13 @@ class tripleo::profile::base::nova::compute::libvirt (
}
}
# TODO(emilien): Some work needs to be done in puppet-nova to separate nova-compute config
# when running libvirt and libvirt itself, so we allow micro-services deployments.
if str2bool(hiera('nova::use_ipv6', false)) {
$vncserver_listen = '::0'
} else {
$vncserver_listen = '0.0.0.0'
}
if $rbd_ephemeral_storage {
class { '::nova::compute::libvirt':
libvirt_disk_cachemodes => ['network=writeback'],
libvirt_hw_disk_discard => 'unmap',
vncserver_listen => $vncserver_listen,
}
} else {
class { '::nova::compute::libvirt' :
vncserver_listen => $vncserver_listen,
}
include ::nova::compute::libvirt
}
include ::nova::compute::libvirt::qemu

7
releasenotes/notes/vncserver_listen-4417377cac38464c.yaml Normal file
View File

@ -0,0 +1,7 @@
---
features:
- Configure VNC server to be binded on internal network interface on compute nodes.
This value comes from tripleo-heat-templates and is configured by default to use
an IP address from the internal API network.
We use the ServiceNetMap in tripleo-heat-templates to compute the IP address, and we won't
configure 0.0.0.0 anymore as it used to open the binding to any network, which is unsecure.