Browse Source

Fix upper case checks for SRIOV interface

Allow using upper case names for SRIOV interface names.

Fixes bug 1848483

Change-Id: I2d2cb42d87371f5807a4527eef22425416d4a774
(cherry picked from commit f5daa7698206dbfa652081f79b0e75075869db48)
changes/01/692101/1
yogananth subramanian 4 months ago
parent
commit
6da86c391f
3 changed files with 10 additions and 1 deletions
  1. +1
    -1
      lib/puppet/type/sriov_vf_config.rb
  2. +3
    -0
      releasenotes/notes/Fixes-SRIOV-upper-case-name-checks-306011421f53131d.yaml
  3. +6
    -0
      spec/unit/type/sriov_vf_config_spec.rb

+ 1
- 1
lib/puppet/type/sriov_vf_config.rb View File

@@ -4,7 +4,7 @@ Puppet::Type.newtype(:sriov_vf_config) do

newparam(:name) do
desc "sriov_numvfs conf as <physical_network>:<number_of_vfs>:<mode> format"
newvalues(/^[a-z0-9\-_]+:[0-9]+(:(switchdev|legacy))?$/)
newvalues(/^[a-zA-Z0-9\-_]+:[0-9]+(:(switchdev|legacy))?$/)
end

end

+ 3
- 0
releasenotes/notes/Fixes-SRIOV-upper-case-name-checks-306011421f53131d.yaml View File

@@ -0,0 +1,3 @@
---
fixes:
- Allow using upper case names for SRIOV interface names.

+ 6
- 0
spec/unit/type/sriov_vf_config_spec.rb View File

@@ -8,6 +8,12 @@ describe 'Puppet::Type.type(:sriov_vf_config)' do
:ensure => 'present'
)}.not_to raise_error
end
it 'should allow name to be passed' do
expect{Puppet::Type.type(:sriov_vf_config).new(
:name => 'eTH0:10',
:ensure => 'present'
)}.not_to raise_error
end
it 'should allow name to be passed with -' do
expect{Puppet::Type.type(:sriov_vf_config).new(
:name => 'eth-0:10',

Loading…
Cancel
Save