diff --git a/lib/puppet/type/sriov_vf_config.rb b/lib/puppet/type/sriov_vf_config.rb index 20746ef5a..78756997c 100644 --- a/lib/puppet/type/sriov_vf_config.rb +++ b/lib/puppet/type/sriov_vf_config.rb @@ -4,7 +4,7 @@ Puppet::Type.newtype(:sriov_vf_config) do newparam(:name) do desc "sriov_numvfs conf as :: format" - newvalues(/^[a-z0-9\-_]+:[0-9]+(:(switchdev|legacy))?$/) + newvalues(/^[a-zA-Z0-9\-_]+:[0-9]+(:(switchdev|legacy))?$/) end end diff --git a/releasenotes/notes/Fixes-SRIOV-upper-case-name-checks-306011421f53131d.yaml b/releasenotes/notes/Fixes-SRIOV-upper-case-name-checks-306011421f53131d.yaml new file mode 100644 index 000000000..9a75a0b79 --- /dev/null +++ b/releasenotes/notes/Fixes-SRIOV-upper-case-name-checks-306011421f53131d.yaml @@ -0,0 +1,3 @@ +--- +fixes: + - Allow using upper case names for SRIOV interface names. diff --git a/spec/unit/type/sriov_vf_config_spec.rb b/spec/unit/type/sriov_vf_config_spec.rb index 8891800b6..c59867bba 100644 --- a/spec/unit/type/sriov_vf_config_spec.rb +++ b/spec/unit/type/sriov_vf_config_spec.rb @@ -8,6 +8,12 @@ describe 'Puppet::Type.type(:sriov_vf_config)' do :ensure => 'present' )}.not_to raise_error end + it 'should allow name to be passed' do + expect{Puppet::Type.type(:sriov_vf_config).new( + :name => 'eTH0:10', + :ensure => 'present' + )}.not_to raise_error + end it 'should allow name to be passed with -' do expect{Puppet::Type.type(:sriov_vf_config).new( :name => 'eth-0:10',