openstack/puppet-tripleo
Code Issues Proposed changes

Revert "Pin puppet-snmp"

Browse Source 
This reverts commit 040857a738.

Reason for revert:
Now rspec-puppet-facts support structured facts and the issue with
unit tests has been resolved.

This change fixes the following error in unit tests, caused by
parameter validation in puppet-snmpd.

Snmp::Snmpv3_user[ro_snmp_user]: parameter 'authpass' expects
a String[8] value, got String

Change-Id: Ib8650d553ae7cef0197a26acac0aa17a04433f28
This commit is contained in:
Takashi Kajinami 2022-02-05 23:41:58 +09:00
parent 6c94352ee9
commit 79dd89c708
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Puppetfile_extras
View File

@ -30,10 +30,9 @@ mod 'ssh',
:git => 'https://github.com/saz/puppet-ssh',
:ref => 'v3.0.1'
# NOTE(aschultz): Pine due to LP#1800944
mod 'snmp',
:git => 'https://github.com/voxpupuli/puppet-snmp',
:ref => '4345049a23cd11e68ac51be13a3a1493a3454370'
:git => 'https://github.com/razorsedge/puppet-snmp',
:ref => 'master'
mod 'pacemaker',
:git => 'https://github.com/openstack/puppet-pacemaker',

14
spec/classes/tripleo_profile_base_snmp_spec.rb
View File

@ -23,7 +23,7 @@ describe 'tripleo::profile::base::snmp' do
let :params do
{
:snmpd_user => 'ro_snmp_user',
:snmpd_password => 'secrete',
:snmpd_password => 'snmppass',
:step => 4,
}
end
@ -31,7 +31,7 @@ describe 'tripleo::profile::base::snmp' do
it 'should configure snmpd' do
is_expected.to contain_class('snmp').with(
:snmpd_config => [
'createUser ro_snmp_user MD5 "secrete"',
'createUser ro_snmp_user MD5 "snmppass"',
'rouser ro_snmp_user',
'proc cron',
'includeAllDisks 10%',
@ -48,7 +48,7 @@ describe 'tripleo::profile::base::snmp' do
let :params do
{
:snmpd_user => 'ro_snmp_user',
:snmpd_password => 'secrete',
:snmpd_password => 'snmppass',
:snmpd_auth_type => 'SHA',
:step => 4,
}
@ -57,7 +57,7 @@ describe 'tripleo::profile::base::snmp' do
it 'should configure snmpd with SHA' do
is_expected.to contain_class('snmp').with(
:snmpd_config => [
'createUser ro_snmp_user SHA "secrete"',
'createUser ro_snmp_user SHA "snmppass"',
'rouser ro_snmp_user',
'proc cron',
'includeAllDisks 10%',
@ -74,9 +74,9 @@ describe 'tripleo::profile::base::snmp' do
let :params do
{
:snmpd_user => 'ro_snmp_user',
:snmpd_password => 'secrete',
:snmpd_password => 'snmppass',
:snmpd_config => [
'createUser ro_snmp_user MD5 "secrete"',
'createUser ro_snmp_user MD5 "snmppass"',
'rouser ro_snmp_user',
'proc neutron-server',
],
@ -87,7 +87,7 @@ describe 'tripleo::profile::base::snmp' do
it 'should configure snmpd with custom parameters' do
is_expected.to contain_class('snmp').with(
:snmpd_config => [
'createUser ro_snmp_user MD5 "secrete"',
'createUser ro_snmp_user MD5 "snmppass"',
'rouser ro_snmp_user',
'proc neutron-server',
]