Add unit tests for manila manifests

Change-Id: Id9f6a41f239dc60378e0495a2e34140800fcfc4f

spec/classes/tripleo_profile_base_manila_api_spec.rb

@@ -0,0 +1,144 @@
+#
+# Copyright (C) 2019 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+require 'spec_helper'
+
+describe 'tripleo::profile::base::manila::api' do
+  shared_examples_for 'tripleo::profile::base::manila::api' do
+
+    before :each do
+      facts.merge!({ :step => params[:step] })
+    end
+
+    let(:pre_condition) do
+      <<-eos
+      class { '::tripleo::profile::base::manila':
+        step => #{params[:step]},
+        oslomsg_rpc_hosts    => [ 'localhost' ],
+        oslomsg_rpc_username => 'manila',
+        oslomsg_rpc_password => 'foo'
+      }
+eos
+    end
+
+    context 'with step less than 3' do
+      let(:params) { {
+        :step => 1,
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('tripleo::profile::base::manila::authtoken')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to_not contain_class('tripleo::profile::base::apache')
+        is_expected.to_not contain_class('manila::api')
+        is_expected.to_not contain_class('manila::wsgi::apache')
+      }
+    end
+
+    context 'with step 3 on bootstrap node' do
+      let(:params) { {
+        :step                    => 3,
+        :bootstrap_node          => 'node.example.com',
+        :backend_generic_enabled => true
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('tripleo::profile::base::manila::authtoken')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::apache')
+        is_expected.to contain_class('manila::api').with(
+          :enabled_share_protocols => 'NFS,CIFS'
+        )
+        is_expected.to contain_class('manila::wsgi::apache')
+      }
+    end
+
+    context 'with step 3 not on bootstrap node' do
+      let(:params) { {
+        :step           => 3,
+        :bootstrap_node => 'other.example.com',
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('tripleo::profile::base::manila::authtoken')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to_not contain_class('tripleo::profile::base::apache')
+        is_expected.to_not contain_class('manila::api')
+        is_expected.to_not contain_class('manila::wsgi::apache')
+      }
+    end
+
+    context 'with step 4' do
+      let(:params) { {
+        :step                    => 4,
+        :bootstrap_node          => 'other.example.com',
+        :backend_generic_enabled => true
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('tripleo::profile::base::manila::authtoken')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::apache')
+        is_expected.to contain_class('manila::api').with(
+          :enabled_share_protocols => 'NFS,CIFS'
+        )
+        is_expected.to contain_class('manila::wsgi::apache')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+      }
+    end
+
+    context 'with cephfs enabled' do
+      let(:params) { {
+        :step                    => 4,
+        :bootstrap_node          => 'node.example.com',
+        :backend_generic_enabled => true,
+        :backend_cephfs_enabled  => true
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('tripleo::profile::base::manila::authtoken')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+        is_expected.to contain_class('tripleo::profile::base::apache')
+        is_expected.to contain_class('manila::api').with(
+          :enabled_share_protocols => 'NFS,CIFS,CEPHFS'
+        )
+        is_expected.to contain_class('manila::wsgi::apache')
+        is_expected.to contain_class('tripleo::profile::base::manila::api')
+      }
+    end
+  end
+
+
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) do
+        facts.merge({ :hostname => 'node.example.com' })
+      end
+
+      it_behaves_like 'tripleo::profile::base::manila::api'
+    end
+  end
+end

spec/classes/tripleo_profile_base_manila_scheduler_spec.rb

@@ -0,0 +1,76 @@
+#
+# Copyright (C) 2019 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+require 'spec_helper'
+
+describe 'tripleo::profile::base::manila::scheduler' do
+  shared_examples_for 'tripleo::profile::base::manila::scheduler' do
+
+    before :each do
+      facts.merge!({ :step => params[:step] })
+    end
+
+    let(:pre_condition) do
+      <<-eos
+      class { '::tripleo::profile::base::manila':
+        step => #{params[:step]},
+        oslomsg_rpc_hosts    => [ 'localhost' ],
+        oslomsg_rpc_username => 'manila',
+        oslomsg_rpc_password => 'foo'
+      }
+eos
+    end
+
+    context 'with step less than 4' do
+      let(:params) { {
+        :step => 3,
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::scheduler')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to_not contain_class('manila::compute::nova')
+        is_expected.to_not contain_class('manila::network::neutron')
+        is_expected.to_not contain_class('manila::scheduler')
+      }
+    end
+
+    context 'with step 4' do
+      let(:params) { {
+        :step => 4,
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::scheduler')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('manila::compute::nova')
+        is_expected.to contain_class('manila::network::neutron')
+        is_expected.to contain_class('manila::scheduler')
+      }
+    end
+  end
+
+
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) do
+        facts.merge({ :hostname => 'node.example.com' })
+      end
+
+      it_behaves_like 'tripleo::profile::base::manila::scheduler'
+    end
+  end
+end

spec/classes/tripleo_profile_base_manila_share_spec.rb

@@ -0,0 +1,78 @@
+#
+# Copyright (C) 2019 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+require 'spec_helper'
+
+describe 'tripleo::profile::base::manila::share' do
+  shared_examples_for 'tripleo::profile::base::manila::share' do
+
+    before :each do
+      facts.merge!({ :step => params[:step] })
+    end
+
+    let(:pre_condition) do
+      <<-eos
+      class { '::tripleo::profile::base::manila':
+        step => #{params[:step]},
+        oslomsg_rpc_hosts    => [ 'localhost' ],
+        oslomsg_rpc_username => 'manila',
+        oslomsg_rpc_password => 'foo'
+      }
+eos
+    end
+
+    context 'with step less than 4' do
+      let(:params) { {
+        :step => 3,
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::share')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to_not contain_class('manila::share')
+        is_expected.to_not contain_class('manila::volume::cinder')
+        is_expected.to_not contain_class('manila::backends')
+      }
+    end
+
+    context 'with step 4' do
+      let(:params) { {
+        :step  => 4,
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila::share')
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('manila::share')
+        is_expected.to_not contain_class('manila::volume::cinder')
+        is_expected.to contain_class('manila::backends').with(
+          :enabled_share_backends => []
+        )
+      }
+    end
+  end
+
+
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) do
+        facts.merge({ :hostname => 'node.example.com' })
+      end
+
+      it_behaves_like 'tripleo::profile::base::manila::share'
+    end
+  end
+end

spec/classes/tripleo_profile_base_manila_spec.rb

@@ -0,0 +1,127 @@
+#
+# Copyright (C) 2019 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+require 'spec_helper'
+
+describe 'tripleo::profile::base::manila' do
+  shared_examples_for 'tripleo::profile::base::manila' do
+    context 'with step less than 3' do
+      let(:params) { {
+        :step                    => 1,
+        :bootstrap_node          => 'node.example.com',
+        :oslomsg_rpc_hosts       => [ '192.168.0.1' ],
+        :oslomsg_rpc_username    => 'manila1',
+        :oslomsg_rpc_password    => 'foo',
+        :oslomsg_rpc_port        => '1234',
+        :oslomsg_notify_hosts    => [ '192.168.0.2' ],
+        :oslomsg_notify_username => 'manila2',
+        :oslomsg_notify_password => 'baa',
+        :oslomsg_notify_port     => '5678'
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to_not contain_class('manila')
+        is_expected.to_not contain_class('manila::config')
+        is_expected.to_not contain_class('manila::logging')
+      }
+    end
+
+    context 'with step 3 on bootstrap node' do
+      let(:params) { {
+        :step                    => 3,
+        :bootstrap_node          => 'node.example.com',
+        :oslomsg_rpc_hosts       => [ '192.168.0.1' ],
+        :oslomsg_rpc_username    => 'manila1',
+        :oslomsg_rpc_password    => 'foo',
+        :oslomsg_rpc_port        => '1234',
+        :oslomsg_notify_hosts    => [ '192.168.0.2' ],
+        :oslomsg_notify_username => 'manila2',
+        :oslomsg_notify_password => 'baa',
+        :oslomsg_notify_port     => '5678'
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('manila').with(
+          :default_transport_url      => 'rabbit://manila1:foo@192.168.0.1:1234/?ssl=0',
+          :notification_transport_url => 'rabbit://manila2:baa@192.168.0.2:5678/?ssl=0'
+        )
+        is_expected.to contain_class('manila::config')
+        is_expected.to contain_class('manila::logging')
+      }
+    end
+
+    context 'with step 3 not on bootstrap node' do
+      let(:params) { {
+        :step                    => 3,
+        :bootstrap_node          => 'note.example.com',
+        :oslomsg_rpc_hosts       => [ '192.168.0.1' ],
+        :oslomsg_rpc_username    => 'manila1',
+        :oslomsg_rpc_password    => 'foo',
+        :oslomsg_rpc_port        => '1234',
+        :oslomsg_notify_hosts    => [ '192.168.0.2' ],
+        :oslomsg_notify_username => 'manila2',
+        :oslomsg_notify_password => 'baa',
+        :oslomsg_notify_port     => '5678'
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to_not contain_class('manila')
+        is_expected.to_not contain_class('manila::config')
+        is_expected.to_not contain_class('manila::logging')
+      }
+    end
+
+    context 'with step 4' do
+      let(:params) { {
+        :step                    => 4,
+        :bootstrap_node          => 'other.example.com',
+        :oslomsg_rpc_hosts       => [ '192.168.0.1' ],
+        :oslomsg_rpc_username    => 'manila1',
+        :oslomsg_rpc_password    => 'foo',
+        :oslomsg_rpc_port        => '1234',
+        :oslomsg_notify_hosts    => [ '192.168.0.2' ],
+        :oslomsg_notify_username => 'manila2',
+        :oslomsg_notify_password => 'baa',
+        :oslomsg_notify_port     => '5678'
+      } }
+
+      it {
+        is_expected.to contain_class('tripleo::profile::base::manila')
+        is_expected.to contain_class('manila').with(
+          :default_transport_url      => 'rabbit://manila1:foo@192.168.0.1:1234/?ssl=0',
+          :notification_transport_url => 'rabbit://manila2:baa@192.168.0.2:5678/?ssl=0'
+        )
+        is_expected.to contain_class('manila::config')
+        is_expected.to contain_class('manila::logging')
+      }
+    end
+
+  end
+
+
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) do
+        facts.merge({ :hostname => 'node.example.com' })
+      end
+
+      it_behaves_like 'tripleo::profile::base::manila'
+    end
+  end
+end

spec/fixtures/hieradata/default.yaml

@@ -63,7 +63,6 @@ heat::keystone::authtoken::password: 'password'
 mysql_short_bootstrap_node_name: node
 # manila related items
 manila::rabbit_password: 'password'
-manila::backend::cephfs::cephfs_protocol_helper_type: 'NFS'
 manila::keystone::authtoken::password: 'password'
 manila_share_short_bootstrap_node_name: 'node.example.com'
 manila_share_short_node_names: