From 8e6e49d28d4db79745371f737a16731f2faad00b Mon Sep 17 00:00:00 2001 From: Michele Baldessari Date: Mon, 4 Oct 2021 12:34:21 +0200 Subject: [PATCH] Add ability to noop a service We want also be able to noop_resource('service'). In order to do that we also add stubs for status, start and stop. Without this it fails with: [root@controller-0 openstack-puppet]# NET_HOST=true DEBUG=True PROCESS_COUNT=1 CONFIG=/root/bandini.json python3 /var/lib/container-puppet/container-puppet.py 2>&1 | tee /tmp/puppet.log |grep Error: <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Could not evaluate: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Failed to call refresh: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Could not evaluate: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Failed to call refresh: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop [root@controller-0 openstack-puppet]# NET_HOST=true DEBUG=True PROCESS_COUNT=1 CONFIG=/root/bandini.json python3 /var/lib/container-puppet/container-puppet.py 2>&1 | tee /tmp/puppet.log |grep Error: <13>Oct 4 10:29:03 puppet-user: Error: Could not set 'running' on ensure: undefined method `start' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop <13>Oct 4 10:29:03 puppet-user: Error: Could not set 'running' on ensure: undefined method `start' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop Related-Bug: #1945962 Change-Id: I9ee8108fe749e787b82f8f4c226f44685ab21a99 --- lib/puppet/functions/noop_resource.rb | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lib/puppet/functions/noop_resource.rb b/lib/puppet/functions/noop_resource.rb index a80b40a0b..5517f4b91 100644 --- a/lib/puppet/functions/noop_resource.rb +++ b/lib/puppet/functions/noop_resource.rb @@ -33,6 +33,17 @@ class Puppet::Provider::Noop < Puppet::Provider false end + def status + 0 + end + + def start + true + end + + def stop + true + end # some puppet-keystone resources require this def self.resource_to_name(domain, name, check_for_default = true) return name