Update patch set 1

Patch Set 1:

(2 comments)

Patch-set: 1
CC: Gerrit User 9816 <9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 9816 2023-01-23 14:45:37 +00:00 committed by Gerrit Code Review
parent 56cc419b90
commit 9790be416e
1 changed files with 50 additions and 0 deletions

View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "cef26cc1_3a3f975f",
"filename": "manifests/profile/base/neutron/ovn_neutron_agent.pp",
"patchSetId": 1
},
"lineNbr": 79,
"author": {
"id": 9816
},
"writtenOn": "2023-01-23T14:45:37Z",
"side": 1,
"message": "the class name should be updated.",
"range": {
"startLine": 79,
"startChar": 39,
"endLine": 79,
"endChar": 51
},
"revId": "d94942a35020640cb03d0240b0fc736d0a89651d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "027d1b8f_6c8d68ad",
"filename": "manifests/profile/base/neutron/ovn_neutron_agent.pp",
"patchSetId": 1
},
"lineNbr": 105,
"author": {
"id": 9816
},
"writtenOn": "2023-01-23T14:45:37Z",
"side": 1,
"message": "This class puts the options to neutron_ovn_metadata_agent.ini but If I read [1] correctly then we need these options in neutron_ovn_agent.ini .\n\n[1] https://review.opendev.org/c/openstack/neutron/+/870024\n\nIf that is correct then we likely have to implement support for this new daemon in puppet-neutron fist (neutron::agents::ovn) then use that implementation here.\n\nNote that we have to support baremetal deployment when we implement support in puppet-neutron. This means we first need to update the RDO package so that files(config files, service unit) for the new service are installed.",
"range": {
"startLine": 105,
"startChar": 13,
"endLine": 105,
"endChar": 42
},
"revId": "d94942a35020640cb03d0240b0fc736d0a89651d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}