openstack
/
puppet-tripleo
Code Issues Proposed changes

Merge "nova: include nova::cinder in more common place"

This commit is contained in:
Zuul 2021-05-05 00:55:55 +00:00 committed by Gerrit Code Review
parent b8d1045be6 6691c97e36
commit acf80e314a
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manifests/profile/base/nova.pp
View File

@ -144,6 +144,7 @@ class tripleo::profile::base::nova (
'ssl' => $oslomsg_notify_use_ssl_real,
}),
}
include nova::cinder
include nova::glance
include nova::placement
include nova::keystone::service_user

1
manifests/profile/base/nova/compute.pp
View File

@ -50,7 +50,6 @@ class tripleo::profile::base::nova::compute (
if $step >= 4 {
# deploy basic bits for nova
include tripleo::profile::base::nova
include nova::cinder
include nova::compute::image_cache
include nova::vendordata
include nova::compute::provider

4
spec/classes/tripleo_profile_base_nova_compute_spec.rb
View File

@ -28,7 +28,6 @@ describe 'tripleo::profile::base::nova::compute' do
it {
is_expected.to contain_class('tripleo::profile::base::nova::compute')
is_expected.to_not contain_class('tripleo::profile::base::nova')
is_expected.to_not contain_class('nova::cinder')
is_expected.to_not contain_class('nova::compute::image_cache')
is_expected.to_not contain_class('nova::vendordata')
is_expected.to_not contain_class('nova::compute')
@ -58,7 +57,6 @@ eos
it {
is_expected.to contain_class('tripleo::profile::base::nova::compute')
is_expected.to contain_class('tripleo::profile::base::nova')
is_expected.to contain_class('nova::cinder')
is_expected.to contain_class('nova::compute::image_cache')
is_expected.to contain_class('nova::vendordata')
is_expected.to contain_class('nova::compute')
@ -86,7 +84,6 @@ eos
it {
is_expected.to contain_class('tripleo::profile::base::nova::compute')
is_expected.to contain_class('tripleo::profile::base::nova')
is_expected.to contain_class('nova::cinder')
is_expected.to contain_class('nova::compute::image_cache')
is_expected.to contain_class('nova::vendordata')
is_expected.to contain_class('nova::compute')
@ -101,7 +98,6 @@ eos
it {
is_expected.to contain_class('tripleo::profile::base::nova::compute')
is_expected.to contain_class('tripleo::profile::base::nova')
is_expected.to contain_class('nova::cinder')
is_expected.to contain_class('nova::compute::image_cache')
is_expected.to contain_class('nova::vendordata')
is_expected.to contain_class('nova::compute')

4
spec/classes/tripleo_profile_base_nova_spec.rb
View File

@ -32,6 +32,7 @@ describe 'tripleo::profile::base::nova' do
is_expected.to_not contain_class('nova::config')
is_expected.to_not contain_class('nova::logging')
is_expected.to_not contain_class('nova::cache')
is_expected.to_not contain_class('nova::cinder')
is_expected.to_not contain_class('nova::glance')
is_expected.to_not contain_class('nova::placement')
is_expected.to_not contain_class('nova::keystone::service_user')
@ -57,6 +58,7 @@ describe 'tripleo::profile::base::nova' do
is_expected.to contain_class('nova::cache').with(
:memcache_servers => ['127.0.0.1:11211']
)
is_expected.to contain_class('nova::cinder')
is_expected.to contain_class('nova::glance')
is_expected.to contain_class('nova::placement')
is_expected.to contain_class('nova::keystone::service_user')
@ -77,6 +79,7 @@ describe 'tripleo::profile::base::nova' do
is_expected.to_not contain_class('nova::config')
is_expected.to_not contain_class('nova::logging')
is_expected.to_not contain_class('nova::cache')
is_expected.to_not contain_class('nova::cinder')
is_expected.to_not contain_class('nova::glance')
is_expected.to_not contain_class('nova::placement')
is_expected.to_not contain_class('nova::keystone::service_user')
@ -102,6 +105,7 @@ describe 'tripleo::profile::base::nova' do
is_expected.to contain_class('nova::config')
is_expected.to contain_class('nova::logging')
is_expected.to contain_class('nova::cache')
is_expected.to contain_class('nova::cinder')
is_expected.to contain_class('nova::glance')
is_expected.to contain_class('nova::placement')
is_expected.to contain_class('nova::keystone::service_user')