openstack
/
puppet-tripleo
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2 Workflow+1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 9816 <9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 62ae06b691ee1a2928d156c142e121f80a692e16
Label: Workflow=+1, f8a0c53a898d4b76ff7c33531ebbbaa9d9f7d168
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 21129 \u003c21129@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
This commit is contained in:
Gerrit User 9816 2023-02-07 01:28:15 +00:00 committed by Gerrit Code Review
parent a1d22c1471
commit b05669e128
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
dfbb5158b7f3eb78d45f954dd860dd53826b038e
View File

@ -17,6 +17,23 @@
"revId": "dfbb5158b7f3eb78d45f954dd860dd53826b038e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a8a14610_3e355d7d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 9816
},
"writtenOn": "2023-02-07T01:28:15Z",
"side": 1,
"message": "Let\u0027s merge this to unblock gate.",
"revId": "dfbb5158b7f3eb78d45f954dd860dd53826b038e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +50,24 @@
"message": "Tripleo no longer uses puppet-etcd [1], but I guess the module should still be pinned as long as the (now deprecated) puppet based THT is still present in THT tree.\n\n[1] https://review.opendev.org/#/q/Ic12715f17e831cb5e1ac8993408f85adcd01a312",
"revId": "dfbb5158b7f3eb78d45f954dd860dd53826b038e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d5bf2bc3_3917bc57",
"filename": "Puppetfile_extras",
"patchSetId": 3
},
"lineNbr": 8,
"author": {
"id": 9816
},
"writtenOn": "2023-02-07T01:28:15Z",
"side": 1,
"message": "As you noted, we still have the deprecated manifest and its unit tests in repo. Especially unit tests can be affected by change in puppet-etcd (though I don\u0027t expect someone will make changes quite actively in that repo).",
"parentUuid": "f6075ed0_90860683",
"revId": "dfbb5158b7f3eb78d45f954dd860dd53826b038e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}