openstack/puppet-tripleo
Code Issues Proposed changes

Use correct manage_firewall hieradata

Browse Source 
The manage_firewall hieradata was moved to
tripleo::firewall::manage_firewall but some of the references to it
were not updated, which makes it impossible to completely disable
the firewall rules.

Change-Id: I5f40f3b8b07bd312cce862aa319b8a1ef331ee49
Closes-Bug: 1679189
This commit is contained in:
Ben Nemec 2017-04-03 14:04:47 +00:00
parent 2e7fbe1d95
commit bc6bfc593e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/haproxy.pp
View File

@ -1377,7 +1377,7 @@ class tripleo::haproxy (
server_names => hiera('mysql_node_names', $controller_hosts_names_real), server_names => hiera('mysql_node_names', $controller_hosts_names_real),
options => $mysql_member_options_real, options => $mysql_member_options_real,
} }
if hiera('manage_firewall', true) { if hiera('tripleo::firewall::manage_firewall', true) {
include ::tripleo::firewall include ::tripleo::firewall
$mysql_firewall_rules = { $mysql_firewall_rules = {
'100 mysql_haproxy' => { '100 mysql_haproxy' => {
@ -1462,7 +1462,7 @@ class tripleo::haproxy (
server_names => hiera('redis_node_names', $controller_hosts_names_real), server_names => hiera('redis_node_names', $controller_hosts_names_real),
options => $haproxy_member_options, options => $haproxy_member_options,
} }
if hiera('manage_firewall', true) { if hiera('tripleo::firewall::manage_firewall', true) {
include ::tripleo::firewall include ::tripleo::firewall
$redis_firewall_rules = { $redis_firewall_rules = {
'100 redis_haproxy' => { '100 redis_haproxy' => {

2
manifests/haproxy/endpoint.pp
View File

@ -147,7 +147,7 @@ define tripleo::haproxy::endpoint (
server_names => $server_names, server_names => $server_names,
options => $member_options, options => $member_options,
} }
if hiera('manage_firewall', true) { if hiera('tripleo::firewall::manage_firewall', true) {
include ::tripleo::firewall include ::tripleo::firewall
# This block will construct firewall rules only when we specify # This block will construct firewall rules only when we specify
# a port for the regular service and also the ssl port for the service. # a port for the regular service and also the ssl port for the service.