openstack
/
puppet-tripleo
Code Issues Proposed changes

Make sure python3-novaclient is installed before creating fence_compute 

This has been observed during an IHA FFU process. Namely
after the OS upgrade by LEAPP the fence_compute resource will
fail starting because python3-novaclient is not installed.
Normally this is taken care of by rpm dependencies, but
fence_compute is buggy and does not explicitely have that
dep (https://bugzilla.redhat.com/show_bug.cgi?id=1857247)

So we need to make sure the package is installed before
creating the resource.

Tested this on four consecutive successful IHA FFU runs
and it worked okay.

Related-Bug: #1888398

Change-Id: I6816d414409da3748b2e341ec05ebcad86ad8fd1
This commit is contained in:
Michele Baldessari 2020-07-15 16:45:35 +02:00
parent 07e0aca242
commit c1e9447998
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/profile/base/pacemaker.pp
View File

@ -254,8 +254,14 @@ class tripleo::profile::base::pacemaker (
}
}
if $enable_instanceha and $pacemaker_master {
include tripleo::profile::base::pacemaker::instance_ha
if $enable_instanceha {
if $pacemaker_master {
include tripleo::profile::base::pacemaker::instance_ha
}
# Until https://bugzilla.redhat.com/show_bug.cgi?id=1857247 is fixed we
# need to make sure the package is installed on the host.
ensure_resource('package', 'python3-novaclient', { ensure => 'installed' })
Package<| name == 'python3-novaclient' |> -> Pcmk_stonith<| title == 'fence-nova' |>
}
if ($step >= 2 and $pacemaker_master) {