openstack
/
puppet-tripleo
Code Issues Proposed changes

Add missing portset parameter to Svf driver 

This patch adds missing configuration parameter 'storwize_portset'
to Cinder IBM Spectrum virtualize family (Svf) driver.

Depends-On: I0b28036bc04b5c0c59347f70273cf0f82848c829
Change-Id: I7734542f710d1aa726b9637847231bb84a368da9
This commit is contained in:
katarimanoj 2023-01-31 14:09:48 +05:30
parent 6372a182e4
commit c30679b77e
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/profile/base/cinder/volume/ibm_svf.pp
View File

@ -38,6 +38,7 @@ class tripleo::profile::base::cinder::volume::ibm_svf (
'CinderSvfIscsiChapEnabled' => lookup('cinder::backend::ibm_svf::storwize_svc_iscsi_chap_enabled', undef, undef, undef),
'CinderSvfRetainAuxVolume' => lookup('cinder::backend::ibm_svf::storwize_svc_retain_aux_volume', undef, undef, undef),
'CinderSvfVolumePoolName' => lookup('cinder::backend::ibm_svf::storwize_svc_volpool_name', undef, undef, undef),
'CinderSvfPortset' => lookup('cinder::backend::ibm_svf::storwize_portset', undef, undef, undef),
}
any2array($backend_name).each |String $backend| {
@ -53,6 +54,7 @@ class tripleo::profile::base::cinder::volume::ibm_svf (
'storwize_svc_iscsi_chap_enabled' => $backend_config['CinderSvfIscsiChapEnabled'],
'storwize_svc_retain_aux_volume' => $backend_config['CinderSvfRetainAuxVolume'],
'storwize_svc_volpool_name' => $backend_config['CinderSvfVolumePoolName'],
'storwize_portset' => $backend_config['CinderSvfPortset'],
})})
}
}

5
releasenotes/notes/Add_missing_portset_param_in_ibm_svf_driver-2da84939d8af2f4e.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Add ``storwize_portset`` parameter to Cinder IBM Spectrum virtualize
family (Svf) driver.

3
spec/classes/tripleo_profile_base_cinder_volume_ibm_svf_spec.rb
View File

@ -47,6 +47,7 @@ describe 'tripleo::profile::base::cinder::volume::ibm_svf' do
:backend_name => ['tripleo_ibm_svf_1', 'tripleo_ibm_svf_2'],
:multi_config => { 'tripleo_ibm_svf_1' => {
'CinderSvfAllowTenantQos' => 'true',
'CinderSvfPortset' => 'portset1',
},
'tripleo_ibm_svf_2' => {
'CinderSvfConnectionProtocol' => 'FC',
@ -58,9 +59,11 @@ describe 'tripleo::profile::base::cinder::volume::ibm_svf' do
is_expected.to contain_cinder__backend__ibm_svf('tripleo_ibm_svf_1')
is_expected.to contain_cinder_config('tripleo_ibm_svf_1/storwize_svc_allow_tenant_qos').with_value('true')
is_expected.to contain_cinder_config('tripleo_ibm_svf_1/volume_driver').with_value('cinder.volume.drivers.ibm.storwize_svc.storwize_svc_iscsi.StorwizeSVCISCSIDriver')
is_expected.to contain_cinder_config('tripleo_ibm_svf_1/storwize_portset').with_value('portset1')
is_expected.to contain_cinder__backend__ibm_svf('tripleo_ibm_svf_2')
is_expected.to contain_cinder_config('tripleo_ibm_svf_2/storwize_svc_allow_tenant_qos').with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config('tripleo_ibm_svf_2/volume_driver').with_value('cinder.volume.drivers.ibm.storwize_svc.storwize_svc_fc.StorwizeSVCFCDriver')
is_expected.to contain_cinder_config('tripleo_ibm_svf_2/storwize_portset').with_value('<SERVICE DEFAULT>')
end
end
end