openstack
/
puppet-tripleo
Code Issues Proposed changes

IHA robustness improvements 

This will avoid useless fencing events in case of stonith problems.  The
'compute-unfence-trigger' resource is simply a dummy resource that is
only used to trigger unfence events. If for whatever reason this
resource is having issues on stop (pcmk bug, node overloaded, etc.) it
makes zero sense to have pacemaker do a fencing action against the node.
Let's just block and show the operator the status and be less harsh in
general.

Tested this and I correctly get the following:
[root@controller-0 ~]# pcs resource show compute-unfence-trigger-clone
 Clone: compute-unfence-trigger-clone
  Resource: compute-unfence-trigger (class=ocf provider=pacemaker type=Dummy)
   Meta Attrs: requires=unfencing
   Operations: migrate_from interval=0s timeout=20 (compute-unfence-trigger-migrate_from-interval-0s)
               migrate_to interval=0s timeout=20 (compute-unfence-trigger-migrate_to-interval-0s)
               monitor interval=10 timeout=20 (compute-unfence-trigger-monitor-interval-10)
               reload interval=0s timeout=20 (compute-unfence-trigger-reload-interval-0s)
               start interval=0s timeout=20 (compute-unfence-trigger-start-interval-0s)
               stop interval=0s on-fail=block timeout=20 (compute-unfence-trigger-stop-interval-0s)

Closes-Bug: #1831234

Change-Id: Ib4884078d54c25da998495ba3e8d47b5e17010ce
(cherry picked from commit 8d2c3a0e6e)
This commit is contained in:
Michele Baldessari 2019-05-28 10:50:16 +02:00 committed by Damien Ciabrini
parent 85692a695b
commit d64f7bfbb4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manifests/profile/base/pacemaker/instance_ha.pp
View File

@ -98,6 +98,7 @@ class tripleo::profile::base::pacemaker::instance_ha (
ocf_agent_name => 'pacemaker:Dummy',
meta_params => 'requires=unfencing',
clone_params => true,
op_params => 'stop timeout=20 on-fail=block',
tries => $pcs_tries,
location_rule => {
resource_discovery => 'never',