openstack/puppet-tripleo
Code Issues Proposed changes

Remove NovaConsoleauth Service

Browse Source 
As of Rocky [1], the nova-consoleauth service has been deprecated and
cell databases are used for storing token authorizations. All new consoles
will be supported by the database backend and existing consoles will be
reset. Console proxies must be run per cell because the new console token
authorizations are stored in cell databases.

nova-consoleauth was deprecated in tripleo with:
I68485a6c4da4476d07ec0ab5e7b5a4c528820a4f

This change now removes the NovaConsoleauth Service.

[1] https://docs.openstack.org/releasenotes/nova/rocky.html

Related-Bug: #1828414

Depends-On: https://review.opendev.org/658081

Change-Id: I55d13aa079f40a97a7aeb60a636d8a7ce1d052c8
This commit is contained in:
Martin Schuppert 2019-05-09 15:55:12 +02:00
parent 5460291800
commit e4039299fc
3 changed files with 15 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
manifests/profile/base/nova/consoleauth.pp
View File

@ -1,33 +0,0 @@
# Copyright 2016 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
# == Class: tripleo::profile::base::nova::consoleauth
#
# Nova Consoleauth profile for tripleo
#
# === Parameters
#
# [*step*]
# (Optional) The current step in deployment. See tripleo-heat-templates
# for more details.
# Defaults to hiera('step')
#
class tripleo::profile::base::nova::consoleauth (
$step = Integer(hiera('step')),
) {
if $step >= 4 {
include ::tripleo::profile::base::nova
include ::nova::consoleauth
}
}

15
releasenotes/notes/nova_remove_nova-consoleauth-c126434b3dbda106.yaml Normal file
View File

@ -0,0 +1,15 @@
---
fixes:
- |
As of Rocky [1], the nova-consoleauth service has been deprecated and
cell databases are used for storing token authorizations. All new consoles
will be supported by the database backend and existing consoles will be
reset. Console proxies must be run per cell because the new console token
authorizations are stored in cell databases.
nova-consoleauth was deprecated in tripleo with:
I68485a6c4da4476d07ec0ab5e7b5a4c528820a4f
This change now removes the NovaConsoleauth Service.
[1] https://docs.openstack.org/releasenotes/nova/rocky.html

62
spec/classes/tripleo_profile_base_nova_consoleauth_spec.rb
View File

@ -1,62 +0,0 @@
#
# Copyright (C) 2017 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
#
require 'spec_helper'
describe 'tripleo::profile::base::nova::consoleauth' do
shared_examples_for 'tripleo::profile::base::nova::consoleauth' do
context 'with step less than 4' do
let(:params) { { :step => 1, } }
it {
is_expected.to contain_class('tripleo::profile::base::nova::consoleauth')
is_expected.to_not contain_class('tripleo::profile::base::nova')
is_expected.to_not contain_class('nova::consoleauth')
}
end
context 'with step 4' do
let(:pre_condition) do
<<-eos
class { '::tripleo::profile::base::nova':
step => #{params[:step]},
oslomsg_rpc_hosts => [ '127.0.0.1' ],
}
eos
end
let(:params) { { :step => 4, } }
it {
is_expected.to contain_class('tripleo::profile::base::nova::consoleauth')
is_expected.to contain_class('tripleo::profile::base::nova')
is_expected.to contain_class('nova::consoleauth')
}
end
end
on_supported_os.each do |os, facts|
context "on #{os}" do
let(:facts) do
facts.merge({ :hostname => 'node.example.com' })
end
it_behaves_like 'tripleo::profile::base::nova::consoleauth'
end
end
end