puppet-tripleo/5ef8c197d3344248c84f0f478f64a5d2cd035bbc

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "81789623_210ac945",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 6
      },
      "lineNbr": 0,
      "author": {
        "id": 20778
      },
      "writtenOn": "2022-03-03T14:12:34Z",
      "side": 1,
      "message": "check-rdo",
      "revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e39d1894_9caea045",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 6
      },
      "lineNbr": 0,
      "author": {
        "id": 20778
      },
      "writtenOn": "2022-03-04T07:57:32Z",
      "side": 1,
      "message": "check-rdo\nfailure during node provisioning",
      "revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "ef603aae_657338c3",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 6
      },
      "lineNbr": 0,
      "author": {
        "id": 9816
      },
      "writtenOn": "2022-03-04T12:05:06Z",
      "side": 1,
      "message": "I\u0027m still trying to understand the exact requirement, but my first impression of this patch is that altering part of url in puppet is too tricky and is hard to maintain.\n\nIMO we should generate a properly encoded password string in tripleo-common as new *Password parameters and use these passwords in t-h-t to compose database url.",
      "revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "bd9dabbb_dd5233b3",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 6
      },
      "lineNbr": 0,
      "author": {
        "id": 20778
      },
      "writtenOn": "2022-03-18T08:45:37Z",
      "side": 1,
      "message": "Fair enough, thanks for the feedback.\nI reworked the approach as you proposed in \nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/833616\nHopefully the commit message in this review and its two dependencies (tripleo-common and puppet-tripleo) explains what I need to achieve.\nEither way, the new review doesn\u0027t bend the content of the hiera keys anymore.",
      "parentUuid": "ef603aae_657338c3",
      "revId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ],
  "submitRequirementResults": [
    {
      "submitRequirement": {
        "name": "Code-Review",
        "description": {
          "value": "Code reviewed by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": true
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Verified",
        "description": {
          "value": "Verified in gate by CI"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Workflow",
        "description": {
          "value": "Approved for gate by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Workflow=MAX","label:Workflow=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "5ef8c197d3344248c84f0f478f64a5d2cd035bbc",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    }
  ]
}